🦀 Comprehensive Clippy run #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on |
Closed
JuaniRios
force-pushed
the
08-13-clippy-changes
branch
2 times, most recently
from
aab7efe
to
1a5b1c8
Compare
JuaniRios
force-pushed
the
08-13-clippy-changes
branch
2 times, most recently
from
54b0e07
to
708be83
Compare
lrazovic
force-pushed
the
08-09-aws_runtime_weight_gen
branch
from
3553e32
to
e294358
Compare
lrazovic
force-pushed
the
08-13-clippy-changes
branch
from
708be83
to
692fa0b
Compare
Closed
JuaniRios
force-pushed
the
08-09-aws_runtime_weight_gen
branch
from
e294358
to
3553e32
Compare
JuaniRios
force-pushed
the
08-13-clippy-changes
branch
from
692fa0b
to
708be83
Compare
This was referenced Aug 16, 2024
Merged
Merged
Merged
lrazovic
force-pushed
the
08-09-aws_runtime_weight_gen
branch
from
3553e32
to
e294358
Compare
lrazovic
force-pushed
the
08-13-clippy-changes
branch
from
708be83
to
692fa0b
Compare
JuaniRios
force-pushed
the
08-09-aws_runtime_weight_gen
branch
from
e294358
to
f28aeb9
Compare
JuaniRios
force-pushed
the
08-13-clippy-changes
branch
2 times, most recently
from
3b913bd
to
0eb41f3
Compare
Merge activity
|
JuaniRios
changed the base branch from
08-09-aws_runtime_weight_gen
to
graphite-base/380
JuaniRios
force-pushed
the
08-13-clippy-changes
branch
from
0eb41f3
to
bf07617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Run clippy::all, which contains the default lint groups (correctness, suspicious, style, complexity, perf)
Why?
We haven't checked clippy in a long time, it provides useful feedback on code style
How?
We define in the workspace the clippy lints we want to run, and the ones we want to ignore
In certain pallets like democracy, which are forks, we don't want to check the clippy there, so we ignore everything.
Anything else?
I started trying to do both all and pedantic groups, but pedantic is huge and would have made the PR bloated.
I implemented some of those changes like the module name repetition, but then stopped.
I will in a later PR cherry pick some lints from pedantic and add them to the workspace