Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍💻 Optional ED inclusion on inst PLMC calculations #311

Merged

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented May 31, 2024

What?

  • Make it possible to add the ED amount to PLMC calculations on evaluations/auctions/contributions

Why?

  • To avoid having to calculate and mint the ED separately

How?

  • Add a new bool with_ed to the functions

Testing?

Existing tests should pass, now that a lot of them were updated

@JuaniRios JuaniRios changed the title optional ed inclusion on inst PLMC calculations 🧑‍💻 Optional ED inclusion on inst PLMC calculations May 31, 2024
@JuaniRios JuaniRios marked this pull request as ready for review May 31, 2024 09:38
@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 31, 2024 09:38
Copy link

graphite-app bot commented May 31, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/31/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

1 similar comment
Copy link

graphite-app bot commented May 31, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/31/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios mentioned this pull request May 31, 2024
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 5e03703 to c2734e9 Compare June 3, 2024 14:16
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from 5b758f0 to 7301163 Compare June 3, 2024 14:16
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from c2734e9 to 00658aa Compare June 3, 2024 14:42
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from 7301163 to 4bffd41 Compare June 3, 2024 14:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 00658aa to 816e301 Compare June 4, 2024 09:32
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from 4bffd41 to c3d4ea1 Compare June 4, 2024 09:32
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, think this is a step in the right direction. I would love to simplify the token minting/assertion interface (not sure yet how) in the long run.

@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 816e301 to 5a10755 Compare June 11, 2024 08:42
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from c3d4ea1 to 8026d9f Compare June 11, 2024 08:42
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 5a10755 to 458cb00 Compare June 11, 2024 09:41
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from 8026d9f to 6c131cf Compare June 11, 2024 09:41
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 458cb00 to 7bcbf6d Compare June 11, 2024 10:25
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from 6c131cf to 33f1c8c Compare June 11, 2024 10:25
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 7bcbf6d to 27538ee Compare June 11, 2024 10:48
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from 33f1c8c to a0424fd Compare June 11, 2024 10:48
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 27538ee to 80fbb7f Compare June 11, 2024 10:50
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from a0424fd to f9a03bf Compare June 11, 2024 10:50
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from 80fbb7f to a3c2e3d Compare June 11, 2024 10:54
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from f9a03bf to f56905c Compare June 11, 2024 10:54
@JuaniRios JuaniRios force-pushed the 05-27-test-freeze-contribution-interaction branch from a3c2e3d to 1c59fc6 Compare June 11, 2024 14:43
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from f56905c to 970dbad Compare June 11, 2024 14:43
Copy link
Contributor Author

JuaniRios commented Jun 11, 2024

Merge activity

  • Jun 11, 10:46 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Jun 11, 10:47 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 11, 10:48 AM EDT: @JuaniRios merged this pull request with Graphite.

Base automatically changed from 05-27-test-freeze-contribution-interaction to main June 11, 2024 14:46
@JuaniRios JuaniRios force-pushed the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch from 970dbad to 8d1510a Compare June 11, 2024 14:46
@JuaniRios JuaniRios merged commit 6ca0b51 into main Jun 11, 2024
@JuaniRios JuaniRios deleted the 05-29-optional_ed_inclusion_on_inst_plmc_calculations branch June 11, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants