Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Paseo config #317

Merged
merged 1 commit into from
Jun 21, 2024
Merged

✨ Paseo config #317

merged 1 commit into from
Jun 21, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 5, 2024 •
edited
Loading

What?

  • Add paseo chain spec
  • Refactor all chain specs

Why?

  • To start our paseo testnet
  • To avoid duplicating code and improve readability

How?

  • Split chain specs into files depending on their relay chain
  • Remove unused live chain specs, keep the json files at ./chain-specs

Testing?

  • Run with zombienet each chain spec and check if we produce blocks

@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jun 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios force-pushed the 06-05-paseo_config branch 4 times, most recently from 98c6ba2 to 4978f0f Compare June 12, 2024 10:25
@JuaniRios JuaniRios self-assigned this Jun 12, 2024
@JuaniRios JuaniRios force-pushed the 06-05-paseo_config branch 3 times, most recently from eaaab2c to 72d9aa7 Compare June 12, 2024 13:22
@JuaniRios JuaniRios changed the title Paseo config ✨ Paseo config Jun 12, 2024
@JuaniRios JuaniRios marked this pull request as ready for review June 12, 2024 13:24
@JuaniRios JuaniRios mentioned this pull request Jun 12, 2024
Merged
@JuaniRios JuaniRios force-pushed the 06-05-paseo_config branch 5 times, most recently from 6a17cd7 to 2c94208 Compare June 17, 2024 12:48
@JuaniRios JuaniRios changed the base branch from main to 06-17-remove_politest_from_integration-tests June 17, 2024 12:48
@JuaniRios JuaniRios mentioned this pull request Jun 17, 2024
Merged
@JuaniRios JuaniRios force-pushed the 06-17-remove_politest_from_integration-tests branch from b10a26f to d3052a5 Compare June 17, 2024 12:59
Base automatically changed from 06-17-remove_politest_from_integration-tests to main June 18, 2024 08:39
vstam1
vstam1 reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think in general it looks pretty good! Couple of comments. Do think its good if Leo has some time to take a second look, as I'm no node side expert, so might not have seen some things.

nodes/parachain/src/chain_spec/common.rs Show resolved Hide resolved
scripts/zombienet/polimec-polkadot-assethub-penpal.toml Outdated Show resolved Hide resolved
scripts/zombienet/polimec-polkadot-assethub-penpal.toml Show resolved Hide resolved
@JuaniRios JuaniRios requested a review from vstam1 June 19, 2024 13:36
@JuaniRios JuaniRios mentioned this pull request Jun 20, 2024
Merged
vstam1
vstam1 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but Leo should definitely do a review as well!

lrazovic
lrazovic requested changes Jun 21, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are ready to take the leap to Paseo!

Adding the raw chainspec to the node would be a huge help when it comes to setting up collators

nodes/parachain/Cargo.toml Outdated Show resolved Hide resolved
nodes/parachain/src/command.rs Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 06-05-paseo_config branch 2 times, most recently from b4a2b7e to 59751ae Compare June 21, 2024 13:04
@JuaniRios JuaniRios requested a review from lrazovic June 21, 2024 13:04
@JuaniRios JuaniRios merged commit 36378a0 into main Jun 21, 2024
@JuaniRios JuaniRios deleted the 06-05-paseo_config branch June 21, 2024 16:02
This was referenced Jun 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 vstam1 approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1