Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Update penpal #322

Merged
merged 1 commit into from
Jun 24, 2024
Merged

⬆️ Update penpal #322

merged 1 commit into from
Jun 24, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 12, 2024 •
edited
Loading

What?

  • Update penpal runtime

Why?

  • To make sure our CT migration works with the latest xcm conventions

How?

  • Replace the old xcm with the new xcm from sdk 1.6.
  • Add the polimec receiver and vesting pallets
  • Modify the xcm config

Testing?

cargo test -p integration-tests

@JuaniRios JuaniRios mentioned this pull request Jun 12, 2024
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jun 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios changed the title update penpal ⬆️ Update penpal Jun 14, 2024
@JuaniRios JuaniRios force-pushed the 06-12-update_penpal branch 3 times, most recently from eccc8cb to f65cc51 Compare June 17, 2024 11:42
@JuaniRios JuaniRios mentioned this pull request Jun 17, 2024
Merged
@JuaniRios JuaniRios force-pushed the 06-12-update_penpal branch 5 times, most recently from 6f34405 to 5d3e21d Compare June 17, 2024 15:24
@JuaniRios JuaniRios self-assigned this Jun 17, 2024
@JuaniRios JuaniRios marked this pull request as ready for review June 17, 2024 15:26
@JuaniRios JuaniRios mentioned this pull request Jun 20, 2024
Merged
vstam1
vstam1 reviewed Jun 21, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
integration-tests/penpal/src/lib.rs Outdated Show resolved Hide resolved
integration-tests/penpal/src/lib.rs Show resolved Hide resolved
integration-tests/penpal/src/xcm_config.rs Show resolved Hide resolved
integration-tests/penpal/src/xcm_config.rs Show resolved Hide resolved
integration-tests/penpal/src/xcm_config.rs Show resolved Hide resolved
integration-tests/penpal/src/xcm_config.rs Show resolved Hide resolved
runtimes/polimec/src/xcm_config.rs Show resolved Hide resolved
Base automatically changed from 06-05-paseo_config to main June 21, 2024 16:02
@JuaniRios JuaniRios requested a review from vstam1 June 24, 2024 09:09
lrazovic
lrazovic approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the conversation around the AllowKnownQueryResponses is resolved (@vstam1), we can merge.

@JuaniRios JuaniRios merged commit 6279d25 into main Jun 24, 2024
@JuaniRios JuaniRios deleted the 06-12-update_penpal branch June 24, 2024 09:26
This was referenced Jun 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1