-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Change XCM execution fee destination to treasury #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
JuaniRios
changed the title
Fix xcm execution fee destinations
🔧 Change XCM execution fee destination to treasury
Jun 13, 2024
JuaniRios
force-pushed
the
06-13-fix_xcm_execution_fee_destinations
branch
from
June 14, 2024 10:40
dcd2502
to
683a1f6
Compare
vstam1
reviewed
Jun 14, 2024
JuaniRios
force-pushed
the
06-13-fix_xcm_execution_fee_destinations
branch
3 times, most recently
from
June 14, 2024 12:31
8c04c69
to
3c1681d
Compare
JuaniRios
force-pushed
the
06-13-fix_xcm_execution_fee_destinations
branch
from
June 14, 2024 12:47
3c1681d
to
27e6b72
Compare
vstam1
reviewed
Jun 14, 2024
JuaniRios
force-pushed
the
06-13-fix_xcm_execution_fee_destinations
branch
2 times, most recently
from
June 14, 2024 13:02
2cffa21
to
db91167
Compare
vstam1
approved these changes
Jun 14, 2024
JuaniRios
force-pushed
the
06-13-fix_xcm_execution_fee_destinations
branch
from
June 14, 2024 13:49
db91167
to
afbc12c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
BuyExecution
, make the amount spent go to the treasury instead of being burntWhy?
💸
How?
XcmConfig::Trader
FixedRateOfFungible
andUsingComponents
which sends to treasury instead of burningTesting?
In integration tests,
xcm_config::execution_fees_go_to_treasury