Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Accept trailing topics on xcm barrier #335

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 24, 2024

What?

  • Make messages with a trailing SetTopic pass the barriers

Why?

  • This is a convention used by parachains. Any query we send will be responded with the response + topic, and currently our barriers don't expect that

How?

  • The wrapper checks if at the end there is a SetTopic, and if so removes it and sets the topic of the executor

Testing?

No tests

Anything Else?

Discussion on the SDK repo:
paritytech/polkadot-sdk#4868

Copy link
Contributor Author

JuaniRios commented Jun 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios force-pushed the 06-24-accept_trailing_topics_on_xcm_barrier branch from f74871a to 42017da Compare June 24, 2024 13:52
@JuaniRios JuaniRios changed the base branch from 06-24-remove_politest to main June 24, 2024 13:52
@JuaniRios JuaniRios self-assigned this Jun 24, 2024
@JuaniRios JuaniRios marked this pull request as ready for review June 24, 2024 13:56
@JuaniRios JuaniRios changed the title Accept trailing topics on xcm barrier 🔧 Accept trailing topics on xcm barrier Jun 24, 2024
@JuaniRios JuaniRios merged commit 0ac2994 into main Jun 24, 2024
@JuaniRios JuaniRios deleted the 06-24-accept_trailing_topics_on_xcm_barrier branch June 24, 2024 14:34
>,
),

pub type Barrier = TrailingSetTopicAsId<
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants