Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make issuer decide migration type #339

Closed
wants to merge 1 commit into from
Closed

Make issuer decide migration type #339

wants to merge 1 commit into from

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 25, 2024 •
edited
Loading

What?

  • Issuer can decide what migration type they want to do
  • Make offchain migrations the default case

Why?

  • Our first projects will do offchain migrations, and we want to test our onchain ones more before we do.
  • So for now we can leave out the call that changes a migration from offchain to receiver pallet (same extrinsic that used to set the para id, now renamed to configure_receiver_pallet_migration

How?

  • Abstract all the receiver pallet migration stuff to an enum variant, where the default variant is the offchain one.

Testing?

  • Normal migration tests

Anything Else?

  • Next step will be to allow issuers to mark the state and all the migrations as completed when the migration type is Offchain...

@JuaniRios JuaniRios mentioned this pull request Jun 25, 2024
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jun 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios force-pushed the 06-25-make_issuer_decide_migration_type branch from 3715737 to ee1f336 Compare June 25, 2024 16:11
@JuaniRios JuaniRios self-assigned this Jun 25, 2024
@JuaniRios JuaniRios marked this pull request as ready for review June 25, 2024 16:17
@JuaniRios JuaniRios force-pushed the 06-25-set_migration_user_to_multilocation branch from b122521 to 1b1c897 Compare June 26, 2024 08:00
@JuaniRios JuaniRios force-pushed the 06-25-make_issuer_decide_migration_type branch from ee1f336 to d7ddd39 Compare June 26, 2024 08:00
@JuaniRios JuaniRios force-pushed the 06-25-set_migration_user_to_multilocation branch from 1b1c897 to 3f99a8f Compare June 26, 2024 09:02
@JuaniRios JuaniRios force-pushed the 06-25-make_issuer_decide_migration_type branch 3 times, most recently from e1e67d5 to 0540faa Compare June 26, 2024 12:09
Base automatically changed from 06-25-set_migration_user_to_multilocation to main June 27, 2024 11:53
@JuaniRios JuaniRios force-pushed the 06-25-make_issuer_decide_migration_type branch from 0540faa to ddd5803 Compare June 27, 2024 11:58
@JuaniRios JuaniRios mentioned this pull request Jun 27, 2024
Merged
@JuaniRios JuaniRios force-pushed the 06-25-make_issuer_decide_migration_type branch from ddd5803 to 8e8c998 Compare June 28, 2024 09:10
@JuaniRios JuaniRios force-pushed the 06-25-make_issuer_decide_migration_type branch from 8e8c998 to d872a60 Compare July 1, 2024 08:27
@JuaniRios JuaniRios marked this pull request as draft July 1, 2024 09:05
@JuaniRios JuaniRios closed this Jul 1, 2024
@JuaniRios JuaniRios deleted the 06-25-make_issuer_decide_migration_type branch August 27, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic Awaiting requested review from lrazovic

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JuaniRios