Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Multiple migration paths #341

Merged
merged 1 commit into from
Jul 8, 2024
Merged

✨ Multiple migration paths #341

merged 1 commit into from
Jul 8, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 27, 2024 •
edited
Loading

What?

  • Pallet migration is no longer hardcoded
  • Issuer decides to go for either Offchain or Pallet migration
  • New states for when the whole project is settled, when the migration starts, and when it ends
  • Issuer can manually confirm migrations on the offchain path

Why?

  • We wanted offchain migrations to be a thing, and currently the logic expected always to be done with the pallet on a parachain

How?

  • New extrinsics
  • Abstracted away the pallet migration logic into an enum inside projectDetails

Testing?

  • New tests for both pallet and offchain migration

Anything Else?

  • Missing benchmarks

This was referenced Jun 27, 2024
Merged
Closed
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jun 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios changed the title offchain migration confirmation ✨ Offchain migration confirmation Jun 27, 2024
@JuaniRios JuaniRios force-pushed the 06-25-make_issuer_decide_migration_type branch from ddd5803 to 8e8c998 Compare June 28, 2024 09:10
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch 4 times, most recently from 521f88e to fe1cb20 Compare June 28, 2024 15:54
@JuaniRios JuaniRios force-pushed the 06-25-make_issuer_decide_migration_type branch from 8e8c998 to d872a60 Compare July 1, 2024 08:27
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch 3 times, most recently from 49253e1 to 0ec3d1b Compare July 1, 2024 12:08
@JuaniRios JuaniRios changed the base branch from 06-25-make_issuer_decide_migration_type to main July 1, 2024 12:08
@JuaniRios JuaniRios changed the title ✨ Offchain migration confirmation ✨ Multiple migration paths Jul 1, 2024
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 0ec3d1b to 34f700c Compare July 1, 2024 12:13
@JuaniRios JuaniRios requested review from lrazovic and vstam1 July 1, 2024 12:13
@JuaniRios JuaniRios self-assigned this Jul 1, 2024
@JuaniRios JuaniRios marked this pull request as ready for review July 1, 2024 12:15
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 34f700c to d3d71ec Compare July 1, 2024 13:14
@JuaniRios JuaniRios changed the base branch from main to 07-01-add_real_weights_to_extrinsics July 1, 2024 13:14
This was referenced Jul 1, 2024
Merged
Merged
Base automatically changed from 07-01-add_real_weights_to_extrinsics to main July 1, 2024 14:02
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from d3d71ec to 8825a75 Compare July 1, 2024 14:05
@JuaniRios JuaniRios mentioned this pull request Jul 1, 2024
Merged
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 8825a75 to 310c142 Compare July 2, 2024 12:31
vstam1
vstam1 requested changes Jul 3, 2024
View reviewed changes
pallets/funding/src/functions/6_settlement.rs Outdated Show resolved Hide resolved
pallets/funding/src/functions/6_settlement.rs Outdated Show resolved Hide resolved
pallets/funding/src/functions/7_ct_migration.rs Outdated Show resolved Hide resolved
pallets/funding/src/functions/7_ct_migration.rs Outdated Show resolved Hide resolved
pallets/funding/src/storage_migrations.rs Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 310c142 to 2b85e8e Compare July 3, 2024 15:41
@JuaniRios JuaniRios requested review from lrazovic and vstam1 July 3, 2024 15:47
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 2b85e8e to 90ec974 Compare July 5, 2024 10:50
@JuaniRios JuaniRios mentioned this pull request Jul 5, 2024
Merged
@lrazovic lrazovic force-pushed the 06-27-offchain_migration_confirmation branch from 90ec974 to 3233bb9 Compare July 5, 2024 15:31
@JuaniRios JuaniRios mentioned this pull request Jul 5, 2024
Merged
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 3233bb9 to 38ebd5d Compare July 5, 2024 15:55
vstam1
vstam1 reviewed Jul 8, 2024
View reviewed changes
pallets/funding/src/functions/misc.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/8_ct_migration.rs Outdated Show resolved Hide resolved
pallets/funding/src/functions/6_settlement.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 38ebd5d to 67ed224 Compare July 8, 2024 10:35
@JuaniRios JuaniRios requested a review from vstam1 July 8, 2024 10:35
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 67ed224 to 137318a Compare July 8, 2024 10:39
vstam1
vstam1 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single dbg left

@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 137318a to ffec6d2 Compare July 8, 2024 11:15
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jul 8, 2024 •
edited
Loading

Merge activity

@JuaniRios JuaniRios merged commit d747738 into main Jul 8, 2024
@JuaniRios JuaniRios deleted the 06-27-offchain_migration_confirmation branch July 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic lrazovic approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1