Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔖 Release 0.7.5 #342

Merged
merged 2 commits into from
Jul 1, 2024
Merged

🔖 Release 0.7.5 #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e0a173
Whitelist settlements
JuaniRios Jun 28, 2024
4c57ad3
chore: remove allow unused
lrazovic Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions runtimes/polimec/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: create_runtime_str!("polimec-mainnet"),
impl_name: create_runtime_str!("polimec-mainnet"),
authoring_version: 1,
spec_version: 0_007_004,
spec_version: 0_007_005,
impl_version: 0,
apis: RUNTIME_API_VERSIONS,
transaction_version: 3,
Expand Down Expand Up @@ -251,7 +251,13 @@ impl Contains<RuntimeCall> for BaseCallFilter {
pallet_funding::Call::root_do_remainder_funding { .. } |
pallet_funding::Call::root_do_end_funding { .. } |
pallet_funding::Call::root_do_project_decision { .. } |
pallet_funding::Call::root_do_start_settlement { .. }
pallet_funding::Call::root_do_start_settlement { .. } |
pallet_funding::Call::settle_successful_evaluation { .. } |
pallet_funding::Call::settle_failed_evaluation { .. } |
pallet_funding::Call::settle_successful_bid { .. } |
pallet_funding::Call::settle_failed_bid { .. } |
pallet_funding::Call::settle_successful_contribution { .. } |
pallet_funding::Call::settle_failed_contribution { .. }
)
},
_ => true,
Expand Down
4 changes: 2 additions & 2 deletions runtimes/shared-configuration/src/funding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use polimec_common::USD_UNIT;
use sp_arithmetic::{FixedU128, Percent};
use sp_std::{collections::btree_map::BTreeMap, vec, vec::Vec};

#[cfg(feature = "fast-mode")]
#[cfg(any(feature = "fast-mode", not(any(feature = "fast-mode", feature = "instant-mode"))))]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify this as we have 3 states. Normal, fast-mode and instant-mode.
We describe normal mode as !(fast-mode or instant-mode). We are currently using Hours in both normal mode and fast-mode, so only not in instant-mode. So think we can change this to cfg(not(feature = "instant-mode")).
Wdty?

use parachains_common::HOURS;

#[cfg(feature = "instant-mode")]
Expand Down Expand Up @@ -86,7 +86,7 @@ pub const SUCCESS_TO_SETTLEMENT_TIME: BlockNumber = 4;
#[cfg(feature = "fast-mode")]
pub const SUCCESS_TO_SETTLEMENT_TIME: BlockNumber = 5 * crate::MINUTES;
#[cfg(not(any(feature = "fast-mode", feature = "instant-mode")))]
pub const SUCCESS_TO_SETTLEMENT_TIME: BlockNumber = 4 * crate::DAYS;
pub const SUCCESS_TO_SETTLEMENT_TIME: BlockNumber = 1 * HOURS;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we completely clear about this change? I understood that the 4 days were for some legal reasons, right? Just wanted to double check that this was cleared with Ken.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are clear. This change follows a discussion we had with the legal team


pub type ProjectIdentifier = u32;

Expand Down