-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Release 0.7.5 #342
π Release 0.7.5 #342
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ use polimec_common::USD_UNIT; | |
use sp_arithmetic::{FixedU128, Percent}; | ||
use sp_std::{collections::btree_map::BTreeMap, vec, vec::Vec}; | ||
|
||
#[cfg(feature = "fast-mode")] | ||
#[cfg(any(feature = "fast-mode", not(any(feature = "fast-mode", feature = "instant-mode"))))] | ||
use parachains_common::HOURS; | ||
|
||
#[cfg(feature = "instant-mode")] | ||
|
@@ -86,7 +86,7 @@ pub const SUCCESS_TO_SETTLEMENT_TIME: BlockNumber = 4; | |
#[cfg(feature = "fast-mode")] | ||
pub const SUCCESS_TO_SETTLEMENT_TIME: BlockNumber = 5 * crate::MINUTES; | ||
#[cfg(not(any(feature = "fast-mode", feature = "instant-mode")))] | ||
pub const SUCCESS_TO_SETTLEMENT_TIME: BlockNumber = 4 * crate::DAYS; | ||
pub const SUCCESS_TO_SETTLEMENT_TIME: BlockNumber = 1 * HOURS; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we completely clear about this change? I understood that the 4 days were for some legal reasons, right? Just wanted to double check that this was cleared with Ken. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we are clear. This change follows a discussion we had with the legal team |
||
|
||
pub type ProjectIdentifier = u32; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simplify this as we have 3 states. Normal, fast-mode and instant-mode.
We describe normal mode as
!(fast-mode or instant-mode)
. We are currently using Hours in both normal mode and fast-mode, so only not in instant-mode. So think we can change this tocfg(not(feature = "instant-mode"))
.Wdty?