-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π¨π»βπ» Reorg extrinsics #345
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
d3d71ec
to
8825a75
Compare
f3f3bb7
to
8d9d697
Compare
Graphite Automations"Auto-assign PRs to author" took an action on this PR β’ (07/02/24)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
8825a75
to
310c142
Compare
8d9d697
to
b0c55cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to keep all the project transition (root) functions together for now. With the project simplifications we will probably move from automatic to semi automatic transitions, so the root function won't be necessary anymore. We will probably rename them and make them available for anyone to be called. However, we might change some protocol flow as well (merge auction rounds, merge community + remainder round and maybe remove decision logic) so we might have to do the reindexing all over again.
In order to minimize the number of times we do a re-index, isn't it better to do it once the protocol simplification has been done? |
Yeah think so as well! |
Right now there is no reason not to reindex. But that might change in the future. So I would rather reindex now since we know there are no side effects. We already have the indexes all over the place |
310c142
to
2b85e8e
Compare
fa96e19
to
2475652
Compare
2b85e8e
to
90ec974
Compare
2475652
to
bb3befb
Compare
90ec974
to
3233bb9
Compare
bb3befb
to
2291bc8
Compare
3233bb9
to
38ebd5d
Compare
2291bc8
to
ed52a7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we probably have to reindex twice, but I won't block the pr if you are convinced
38ebd5d
to
67ed224
Compare
ed52a7e
to
efefeed
Compare
67ed224
to
137318a
Compare
efefeed
to
904bf50
Compare
137318a
to
ffec6d2
Compare
904bf50
to
b178463
Compare
Merge activity
|
b178463
to
dc1952c
Compare
What?
Change the order, naming, and indexing of some extrinsics
Why?
Easier readability, and less guessing what the next index will be for new extrinsics