Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘¨πŸ»β€πŸ’» Reorg extrinsics #345

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 1, 2024

What?

Change the order, naming, and indexing of some extrinsics

Why?

Easier readability, and less guessing what the next index will be for new extrinsics

@JuaniRios JuaniRios changed the title new benchmarks πŸ‘¨πŸ»β€πŸ’» Reorg extrinsics Jul 1, 2024
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from d3d71ec to 8825a75 Compare July 1, 2024 14:05
@JuaniRios JuaniRios marked this pull request as ready for review July 2, 2024 07:20
@JuaniRios JuaniRios requested review from lrazovic and vstam1 July 2, 2024 07:20
Copy link

graphite-app bot commented Jul 2, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR β€’ (07/02/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 8825a75 to 310c142 Compare July 2, 2024 12:31
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to keep all the project transition (root) functions together for now. With the project simplifications we will probably move from automatic to semi automatic transitions, so the root function won't be necessary anymore. We will probably rename them and make them available for anyone to be called. However, we might change some protocol flow as well (merge auction rounds, merge community + remainder round and maybe remove decision logic) so we might have to do the reindexing all over again.

@lrazovic
Copy link
Member

lrazovic commented Jul 3, 2024

However, we might change some protocol flow as well (merge auction rounds, merge community + remainder round and maybe remove decision logic) so we might have to do the reindexing all over again.

In order to minimize the number of times we do a re-index, isn't it better to do it once the protocol simplification has been done?

@vstam1
Copy link
Collaborator

vstam1 commented Jul 3, 2024

Yeah think so as well!

Copy link
Contributor Author

However, we might change some protocol flow as well (merge auction rounds, merge community + remainder round and maybe remove decision logic) so we might have to do the reindexing all over again.

In order to minimize the number of times we do a re-index, isn't it better to do it once the protocol simplification has been done?

Right now there is no reason not to reindex. But that might change in the future. So I would rather reindex now since we know there are no side effects.

We already have the indexes all over the place

@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 310c142 to 2b85e8e Compare July 3, 2024 15:41
@JuaniRios JuaniRios force-pushed the 07-01-new_benchmarks branch 2 times, most recently from fa96e19 to 2475652 Compare July 3, 2024 15:44
@JuaniRios JuaniRios requested a review from vstam1 July 3, 2024 15:47
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 2b85e8e to 90ec974 Compare July 5, 2024 10:50
@lrazovic lrazovic force-pushed the 06-27-offchain_migration_confirmation branch from 90ec974 to 3233bb9 Compare July 5, 2024 15:31
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 3233bb9 to 38ebd5d Compare July 5, 2024 15:55
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that we probably have to reindex twice, but I won't block the pr if you are convinced

@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 38ebd5d to 67ed224 Compare July 8, 2024 10:35
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 67ed224 to 137318a Compare July 8, 2024 10:39
@JuaniRios JuaniRios force-pushed the 06-27-offchain_migration_confirmation branch from 137318a to ffec6d2 Compare July 8, 2024 11:15
Copy link
Contributor Author

JuaniRios commented Jul 8, 2024

Merge activity

  • Jul 8, 8:35 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Jul 8, 8:36 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 8, 8:37 AM EDT: @JuaniRios merged this pull request with Graphite.

Base automatically changed from 06-27-offchain_migration_confirmation to main July 8, 2024 12:35
@JuaniRios JuaniRios merged commit 6c2814a into main Jul 8, 2024
@JuaniRios JuaniRios deleted the 07-01-new_benchmarks branch July 8, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants