Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Compilation #364

Merged
merged 1 commit into from
Aug 23, 2024
Merged

🐛 Fix Compilation #364

merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 22, 2024 •
edited
Loading

What?

  • Make the repo compile for a release build and testing

Why?

  • Can't start fixing tests if it won't even compile

How?

  • Remove pallet-sandbox (was pretty old already and not in use)
  • Remove old migration code and runtime item
  • Add FundingSuccessThreshold (33%) to runtime
  • Fix basecall filter

Testing?

  • cargo build --release and cargo test on root folder

Anything Else?

  • Benchmarks still not compiling, will take significant rewrite

@JuaniRios JuaniRios changed the title simplifications part 4 Fix Compilation Jul 22, 2024
This was referenced Jul 22, 2024
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jul 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 0f8da6a to 8151325 Compare July 22, 2024 12:26
@JuaniRios JuaniRios changed the title Fix Compilation 🐛 Fix Compilation Jul 22, 2024
@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from c590033 to 447b78a Compare July 22, 2024 14:33
@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 8151325 to 10e51b1 Compare July 22, 2024 14:33
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from 447b78a to fe0f499 Compare July 22, 2024 14:57
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 10e51b1 to 944d94a Compare July 22, 2024 14:57
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from fe0f499 to 67bf472 Compare July 22, 2024 15:03
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch 2 times, most recently from e480b04 to 5d4ca77 Compare July 22, 2024 15:10
This was referenced Jul 26, 2024
Merged
Merged
vstam1
vstam1 requested changes Aug 2, 2024
View reviewed changes
pallets/funding/src/functions/misc.rs Show resolved Hide resolved
pallets/funding/src/storage_migrations.rs Outdated Show resolved Hide resolved
runtimes/polimec/src/lib.rs Outdated Show resolved Hide resolved
runtimes/polimec/src/lib.rs Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from 67bf472 to c2065c1 Compare August 5, 2024 09:45
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch 2 times, most recently from 5e21667 to 0069666 Compare August 5, 2024 10:06
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from c2065c1 to 2a73180 Compare August 5, 2024 10:17
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch 2 times, most recently from b1d13b0 to 377f267 Compare August 5, 2024 10:33
@JuaniRios JuaniRios mentioned this pull request Aug 5, 2024
Merged
@JuaniRios JuaniRios self-assigned this Aug 5, 2024
@JuaniRios JuaniRios mentioned this pull request Aug 5, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_3 branch from 2a73180 to 67d55e8 Compare August 5, 2024 14:35
This was referenced Aug 6, 2024
Merged
Merged
Merged
Merged
Closed
This was referenced Aug 9, 2024
Merged
Merged
This was referenced Aug 13, 2024
Closed
Closed
Merged
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_3 branch from 64243b0 to 5f28258 Compare August 16, 2024 13:03
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_4 branch from ec5fc28 to d353b87 Compare August 16, 2024 13:03
@lrazovic lrazovic mentioned this pull request Aug 16, 2024
Closed
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_3 branch from 64243b0 to 5f28258 Compare August 16, 2024 13:13
@lrazovic lrazovic force-pushed the 07-22-simplifications_part_4 branch from ec5fc28 to d353b87 Compare August 16, 2024 13:13
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024 •
edited
Loading

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:07 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:08 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 07-22-simplifications_part_3 to graphite-base/364 August 23, 2024 10:03
@JuaniRios JuaniRios changed the base branch from graphite-base/364 to main August 23, 2024 10:05
@JuaniRios JuaniRios merged commit 80f59b0 into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 07-22-simplifications_part_4 branch August 23, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 vstam1 approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1