Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Rework tests #365

Merged
merged 1 commit into from
Aug 23, 2024
Merged

🛠️ Rework tests #365

merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 22, 2024 •
edited
Loading

What?

  • Fix pallet and integration tests
  • Improve instantiator flow
  • Merged community and remainder test files into one

To reviewers:

  • You will have to go review all the tests since a lot of the changed significantly, and the diff is kinda broken, sry

This was referenced Jul 22, 2024
Merged
Merged
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jul 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios changed the title Fix existing tests 🛠️ Fix existing tests Jul 22, 2024
@JuaniRios JuaniRios mentioned this pull request Jul 22, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 8151325 to 10e51b1 Compare July 22, 2024 14:33
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 10e51b1 to 944d94a Compare July 22, 2024 14:57
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from 944d94a to e480b04 Compare July 22, 2024 15:03
@JuaniRios JuaniRios force-pushed the 07-22-simplifications_part_4 branch from e480b04 to 5d4ca77 Compare July 22, 2024 15:10
@JuaniRios JuaniRios force-pushed the 07-22-fix_existing_tests branch 6 times, most recently from 59c1e45 to 1cc7d39 Compare July 26, 2024 10:01
@JuaniRios JuaniRios changed the base branch from 07-22-simplifications_part_4 to 07-26-simplifications_part_5 July 26, 2024 10:01
@JuaniRios JuaniRios mentioned this pull request Jul 26, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 436ee42 to ca95c55 Compare July 26, 2024 13:13
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from ca95c55 to 1f39ae7 Compare July 26, 2024 14:38
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 1f39ae7 to 2be0264 Compare July 26, 2024 14:59
This was referenced Aug 8, 2024
Closed
Merged
@JuaniRios JuaniRios changed the title 🛠️ Fix existing tests 🛠️ Rework tests Aug 9, 2024
@JuaniRios JuaniRios mentioned this pull request Aug 9, 2024
Merged
lrazovic
lrazovic approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits here and there, but overall looks good.

pallets/funding/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/funding/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/3_auction.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/3_auction.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/5_funding_end.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/5_funding_end.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/runtime_api.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/runtime_api.rs Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from aabcdb5 to 5e0e89d Compare August 13, 2024 09:04
@JuaniRios JuaniRios mentioned this pull request Aug 13, 2024
Closed
@JuaniRios JuaniRios force-pushed the 07-22-fix_existing_tests branch 2 times, most recently from b0541cd to 508f4a1 Compare August 13, 2024 09:38
This was referenced Aug 13, 2024
Closed
Merged
@lrazovic lrazovic force-pushed the 07-30-remove_unnecessary_bid_fields branch from 5e0e89d to 49e8d93 Compare August 16, 2024 13:03
@lrazovic lrazovic mentioned this pull request Aug 16, 2024
Closed
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 49e8d93 to 5e0e89d Compare August 16, 2024 13:09
@lrazovic lrazovic force-pushed the 07-30-remove_unnecessary_bid_fields branch from 5e0e89d to 49e8d93 Compare August 16, 2024 13:13
vstam1
vstam1 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of comments about removing dbg statements

pallets/funding/src/instantiator/calculations.rs Show resolved Hide resolved
pallets/funding/src/tests/6_settlement.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 49e8d93 to 5e0e89d Compare August 22, 2024 12:57
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024 •
edited
Loading

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:16 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:17 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 07-30-remove_unnecessary_bid_fields to graphite-base/365 August 23, 2024 10:12
@JuaniRios JuaniRios changed the base branch from graphite-base/365 to main August 23, 2024 10:14
@JuaniRios JuaniRios merged commit cf671be into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 07-22-fix_existing_tests branch August 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 vstam1 approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1