Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗑️ Remove unnecessary bid fields #367

Merged
merged 1 commit into from
Aug 23, 2024
Merged

🗑️ Remove unnecessary bid fields #367

merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 30, 2024 •
edited
Loading

What?

  • Remove fields in BidInfo which were not needed
  • Make retail multiplier limits a fixed range

Why?

  • Less storage bloat
  • Simplified logic, less storage overhead to keep track of past participations

Testing?

  • In the next PR

This was referenced Jul 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jul 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Jul 30, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 0f61954 to 0e334fa Compare July 30, 2024 11:28
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from b612f1d to 4e36554 Compare July 30, 2024 11:29
@JuaniRios JuaniRios changed the title Remove unnecessary bid fields 🗑️ Remove unnecessary bid fields Aug 2, 2024
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 4e36554 to 75c005f Compare August 2, 2024 14:08
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 0e334fa to 291cb86 Compare August 5, 2024 09:46
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 75c005f to 32dc630 Compare August 5, 2024 09:46
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 291cb86 to f1168a6 Compare August 5, 2024 10:06
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 32dc630 to 69b1363 Compare August 5, 2024 10:06
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from f1168a6 to 0101bb2 Compare August 5, 2024 10:08
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch 2 times, most recently from f9ef402 to 6349be2 Compare August 5, 2024 10:11
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 0101bb2 to a498df9 Compare August 5, 2024 10:17
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 6349be2 to 050c526 Compare August 5, 2024 10:17
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from a498df9 to 7b27530 Compare August 5, 2024 10:33
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 050c526 to f3ce8f0 Compare August 5, 2024 10:33
@JuaniRios JuaniRios mentioned this pull request Aug 5, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from f3ce8f0 to 204cd85 Compare August 5, 2024 10:49
@JuaniRios JuaniRios self-assigned this Aug 5, 2024
@JuaniRios JuaniRios mentioned this pull request Aug 5, 2024
Merged
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from 7b27530 to 77481cd Compare August 5, 2024 14:35
@JuaniRios JuaniRios force-pushed the 07-26-simplifications_part_5 branch from f89881e to 3219bc8 Compare August 6, 2024 09:30
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from a8858fe to aabcdb5 Compare August 6, 2024 09:30
This was referenced Aug 6, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from aabcdb5 to 5e0e89d Compare August 13, 2024 09:04
This was referenced Aug 13, 2024
Closed
Closed
Merged
@lrazovic lrazovic force-pushed the 07-26-simplifications_part_5 branch from 494a503 to 52e7d53 Compare August 16, 2024 13:03
@lrazovic lrazovic force-pushed the 07-30-remove_unnecessary_bid_fields branch from 5e0e89d to 49e8d93 Compare August 16, 2024 13:03
@lrazovic lrazovic mentioned this pull request Aug 16, 2024
Closed
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 49e8d93 to 5e0e89d Compare August 16, 2024 13:09
@lrazovic lrazovic force-pushed the 07-26-simplifications_part_5 branch from 494a503 to 52e7d53 Compare August 16, 2024 13:13
@lrazovic lrazovic force-pushed the 07-30-remove_unnecessary_bid_fields branch from 5e0e89d to 49e8d93 Compare August 16, 2024 13:13
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 49e8d93 to 5e0e89d Compare August 22, 2024 12:57
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024 •
edited
Loading

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:13 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:14 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 07-26-simplifications_part_5 to graphite-base/367 August 23, 2024 10:09
@JuaniRios JuaniRios changed the base branch from graphite-base/367 to main August 23, 2024 10:11
@JuaniRios JuaniRios force-pushed the 07-30-remove_unnecessary_bid_fields branch from 5e0e89d to b904835 Compare August 23, 2024 10:12
@JuaniRios JuaniRios merged commit 7b4d80c into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 07-30-remove_unnecessary_bid_fields branch August 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1