Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Remove AuctionClosingDuration #369

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Aug 5, 2024

What?

  • There's no more candle period, so AuctionOpening and AuctionClosing durations should be merged
  • Naming of durations are now more consistent

How?

  • Removed both Auction periods and replaced them for one called AuctionRoundDuration
  • Merged the durations in the shared-configuration

Testing?

We moved from transitioning using the durations to the simple extrinsic inst.go_to_next_state(project_id) so no text fixes needed.

Anything Else?

  • Made all mock durations different to potentially catch some bugs. Had a problem before where I was assuming a closing duration was going on and it was the auctionInitializePeriod.

@JuaniRios JuaniRios changed the title Remove AuctionClosingDuration 💥 Remove AuctionClosingDuration Aug 5, 2024
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 50ccc77 to e2f1a55 Compare August 5, 2024 14:36
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from 0a1e4a9 to c19460b Compare August 5, 2024 14:36
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from e2f1a55 to cf5e7ff Compare August 5, 2024 14:40
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from c19460b to 3099a06 Compare August 5, 2024 14:40
@JuaniRios JuaniRios mentioned this pull request Aug 5, 2024
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from cf5e7ff to 0364aa1 Compare August 5, 2024 14:42
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from 3099a06 to e35873d Compare August 5, 2024 14:42
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 0364aa1 to cc9f647 Compare August 5, 2024 14:49
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from e35873d to d0caa30 Compare August 5, 2024 14:49
@JuaniRios JuaniRios marked this pull request as ready for review August 5, 2024 14:51
Copy link

graphite-app bot commented Aug 5, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (08/05/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's also remove the randomness pallet from the Runtime and the Mock

@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from cc9f647 to 628bc49 Compare August 6, 2024 09:30
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from d0caa30 to d150cd7 Compare August 6, 2024 09:30
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 628bc49 to 4d2034b Compare August 6, 2024 11:42
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 16913f6 to 780a65d Compare August 13, 2024 09:04
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from 557ade7 to 5d4e4af Compare August 13, 2024 09:04
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 780a65d to ccec8a8 Compare August 13, 2024 09:27
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from 5d4e4af to 55d9c57 Compare August 13, 2024 09:27
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from ccec8a8 to 6f6ac57 Compare August 13, 2024 09:38
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from 55d9c57 to 32133e0 Compare August 13, 2024 09:38
This was referenced Aug 13, 2024
@lrazovic lrazovic force-pushed the 08-05-fix_project_transition_event branch from 6f6ac57 to 0712fc1 Compare August 16, 2024 13:03
@lrazovic lrazovic force-pushed the 08-05-remove_auctionclosingduration branch from 32133e0 to ab29b00 Compare August 16, 2024 13:03
@lrazovic lrazovic mentioned this pull request Aug 16, 2024
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 0712fc1 to 6f6ac57 Compare August 16, 2024 13:09
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from ab29b00 to 32133e0 Compare August 16, 2024 13:09
@lrazovic lrazovic force-pushed the 08-05-fix_project_transition_event branch from 6f6ac57 to 0712fc1 Compare August 16, 2024 13:13
@lrazovic lrazovic force-pushed the 08-05-remove_auctionclosingduration branch from 32133e0 to ab29b00 Compare August 16, 2024 13:13
@JuaniRios JuaniRios force-pushed the 08-05-fix_project_transition_event branch from 0712fc1 to 6f6ac57 Compare August 22, 2024 12:57
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from ab29b00 to 32133e0 Compare August 22, 2024 12:57
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:25 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:26 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 08-05-fix_project_transition_event to graphite-base/369 August 23, 2024 10:20
@JuaniRios JuaniRios changed the base branch from graphite-base/369 to main August 23, 2024 10:23
@JuaniRios JuaniRios force-pushed the 08-05-remove_auctionclosingduration branch from 32133e0 to b4f6010 Compare August 23, 2024 10:24
@JuaniRios JuaniRios merged commit 338baae into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 08-05-remove_auctionclosingduration branch August 23, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants