Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🙅🏻‍♂️ Disallow 0CT participation #385

Merged
merged 2 commits into from
Sep 3, 2024
Merged

🙅🏻‍♂️ Disallow 0CT participation #385

merged 2 commits into from
Sep 3, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Aug 30, 2024 •
edited
Loading

What?

  • Participants could contribute with 0CTs, now we disallow it

Why?

  • Useless storage consumption

How?

  • an ensure on the final ct bought

Testing?

  • New test

@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Aug 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

This was referenced Aug 30, 2024
Merged
Merged
Merged
Closed
@JuaniRios JuaniRios force-pushed the 08-30-disallow_0ct_participation branch from 5095eec to 0905da2 Compare August 30, 2024 14:29
@JuaniRios JuaniRios changed the base branch from main to 08-30-fix_penpal August 30, 2024 14:29
@JuaniRios JuaniRios mentioned this pull request Aug 30, 2024
Merged
@lrazovic lrazovic force-pushed the 08-30-disallow_0ct_participation branch from 0905da2 to 3ca9df8 Compare August 30, 2024 15:43
@JuaniRios JuaniRios force-pushed the 08-30-disallow_0ct_participation branch from 3ca9df8 to 0905da2 Compare September 2, 2024 08:33
@JuaniRios JuaniRios marked this pull request as ready for review September 2, 2024 09:37
@JuaniRios JuaniRios changed the title disallow 0CT participation 🙅🏻‍♂️ Disallow 0CT participation Sep 2, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 2, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (09/02/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios mentioned this pull request Sep 3, 2024
Merged
This was referenced Sep 3, 2024
Closed
Merged
Merged
This was referenced Sep 3, 2024
Merged
Merged
Merged
@lrazovic lrazovic force-pushed the 08-30-disallow_0ct_participation branch from 0905da2 to 3ca9df8 Compare September 3, 2024 13:55
@JuaniRios JuaniRios force-pushed the 08-30-disallow_0ct_participation branch from 3ca9df8 to 0905da2 Compare September 3, 2024 14:05
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Sep 3, 2024 •
edited
Loading

Merge activity

  • Sep 3, 10:13 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Sep 3, 10:15 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Sep 3, 10:15 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 08-30-fix_penpal to graphite-base/385 September 3, 2024 14:13
@JuaniRios JuaniRios changed the base branch from graphite-base/385 to main September 3, 2024 14:13
@JuaniRios JuaniRios merged commit 56918d4 into main Sep 3, 2024
1 check passed
@JuaniRios JuaniRios deleted the 08-30-disallow_0ct_participation branch September 3, 2024 14:15
This was referenced Sep 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic