-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1️⃣ One Token Model - New Pallet Proxy Bonding #399
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
0cae26c
to
9b93ff0
Compare
9b93ff0
to
6d96f7b
Compare
9cea8b2
to
1e0a680
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits here and there, but the logic looks good and aligns with what we discussed. Just a few minor issues to iron out. I'll approve this once we have some integration tests in place to verify it works as expected on our runtime.
edf4404
to
b13ff8f
Compare
b13ff8f
to
70655e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think logic looks good. Couple of comments, but can be merged once comments are addressed
70655e3
to
8c6cb4a
Compare
8c6cb4a
to
8613b59
Compare
8613b59
to
8c6cb4a
Compare
8c6cb4a
to
8613b59
Compare
8613b59
to
8c6cb4a
Compare
8c6cb4a
to
70e28e5
Compare
What?
Why?
How?
bond_on_behalf_of
which takes the account, bond amount, fee asset id, derivation path (project id), and the hold reason.set_release_type
decides whether the the fee will go to the configured fee recipient, or will be refunded. Also decides if the bond can be immediately send back to the treasury, or after a set blockrefund_fee
refunds the fee of a certain user/bond if the release type was configured as refunded.transfer_bonds_back_to_treasury
does what the name entails, and checks the release type for when it can be done successfullytransfer_fees_to_recipient
does what the name entails, only if the release type isLocked(n)
and notRefunded
Testing?
One for each release type.
Anything Else?
If the design is approved by the reviewers, I can include the integration tests in a separate PR after this.