Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤝 One Token Model - Pallet Funding Integration #401

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Sep 18, 2024

What?

Integrate the OTM flow in pallet-funding

How?

  • Tightly couple pallet-proxy-bonding with pallet-funding
  • Abstract multiplier parameter in extrinsic to an enum called ParticipationMode with variants Classic(multiplier) and OTM
  • Abstract the plmc bonding to a new function that takes the participation mode, and either does the classic bonding, or calls the proxy-bonding logic
  • On settlement start, set the release type to Refunded or Locked in proxy-bonding pallet.
  • On participation settlements, if the project failed, or a bid has some refund, call the refund_fee of proxy-bonding

Testing?

In the next PR

@JuaniRios JuaniRios changed the title pallet funding OTM integration 🤝 OTM integration Sep 18, 2024
@JuaniRios JuaniRios changed the title 🤝 OTM integration 🤝 OTM funding integration Sep 18, 2024
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch 3 times, most recently from 3849071 to 59622fb Compare September 18, 2024 14:14
@JuaniRios JuaniRios changed the title 🤝 OTM funding integration 🤝 One Token Model - pallet-funding integration Sep 19, 2024
@JuaniRios JuaniRios changed the title 🤝 One Token Model - pallet-funding integration 🤝 One Token Model - Pallet Funding Integration Sep 19, 2024
@JuaniRios JuaniRios changed the title 🤝 One Token Model - Pallet Funding Integration 🤝 One Token Model - Pallet Funding Integration Sep 19, 2024
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 59622fb to 7b27337 Compare September 20, 2024 12:04
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch 5 times, most recently from 0cce953 to a04bf46 Compare September 23, 2024 10:51
@JuaniRios JuaniRios self-assigned this Sep 24, 2024
@JuaniRios JuaniRios marked this pull request as ready for review September 24, 2024 10:46
pallets/funding/src/types.rs Outdated Show resolved Hide resolved
runtimes/polimec/src/lib.rs Outdated Show resolved Hide resolved
pallets/funding/src/lib.rs Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch 3 times, most recently from 2ddbf09 to 0631f96 Compare September 30, 2024 13:14
pallets/funding/src/lib.rs Show resolved Hide resolved
pallets/funding/src/types.rs Show resolved Hide resolved
runtimes/polimec/src/lib.rs Show resolved Hide resolved
pallets/funding/src/functions/6_settlement.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 0631f96 to 70e3fed Compare October 3, 2024 13:49
@JuaniRios JuaniRios requested a review from vstam1 October 3, 2024 14:55
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 70e3fed to 6a561be Compare October 9, 2024 09:59
@lrazovic lrazovic force-pushed the 09-18-pallet_funding_otm_integration branch from 6a561be to 6836ed8 Compare October 10, 2024 11:57
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 6836ed8 to 6a561be Compare October 10, 2024 11:59
@lrazovic lrazovic force-pushed the 09-18-pallet_funding_otm_integration branch from 6a561be to 6836ed8 Compare October 10, 2024 12:20
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 6836ed8 to 6a561be Compare October 10, 2024 12:22
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from 6a561be to dd5ba75 Compare October 10, 2024 13:46
Copy link
Contributor Author

JuaniRios commented Oct 10, 2024

Merge activity

  • Oct 10, 10:08 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 10:10 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 10:11 AM EDT: A user merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 09-10-one-token-model to graphite-base/401 October 10, 2024 14:08
@JuaniRios JuaniRios changed the base branch from graphite-base/401 to main October 10, 2024 14:08
@JuaniRios JuaniRios force-pushed the 09-18-pallet_funding_otm_integration branch from dd5ba75 to 5e7d2f4 Compare October 10, 2024 14:09
@JuaniRios JuaniRios merged commit 352f607 into main Oct 10, 2024
1 check passed
@JuaniRios JuaniRios deleted the 09-18-pallet_funding_otm_integration branch October 10, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants