Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bondtype changes #45

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Bondtype changes #45

merged 9 commits into from
Jun 26, 2023

Conversation

JuaniRios
Copy link
Contributor

  • We unify bids and contributions under one lock type called "Participation".
  • Rename BondType -> LockType to follow the documentation
  • Evaluation-locked plmc, can now be used for participating (i.e bids and contributions)
  • Instantiating Projects with the test framework now works with evaluators being participants.
  • New tests for edge cases
  • New tests for helper functions when calculating PLMC spent (they all passed on the first try, so all good 😄 )

… and `Participation`.

`merge_mappings_by_user` now can accept any mapping of any length without being pre-sorted. It will sort them and either sum 2 existing users or append them in order.
…PLMC amount required on evaluations, bids, and contributions
@linear
Copy link

linear bot commented Jun 23, 2023

PLMC-209 BondType changes

  • No more distinction between each phase. Only the project it was made for.
  • Evaluation bonds should still be available to be used for bids and contributions. Therefore the evaluation bond should be a different category.
  • Leave LongTermHolderBonus out for now

Idea :

BondType<ProjectId> {
   Evaluation(ProjectId),
   Participation(ProjectId), // bids, contributions
}

The changes on the BondType struct will imply a lot of other changes in the protocol.

For example, the unvesting functions were separated into each bond type

leonardo thoughts?

@JuaniRios JuaniRios self-assigned this Jun 23, 2023
@JuaniRios JuaniRios requested a review from lrazovic June 23, 2023 15:27
@JuaniRios JuaniRios added the enhancement New feature or request label Jun 23, 2023
polimec-skeleton/pallets/funding/src/lib.rs Outdated Show resolved Hide resolved
polimec-skeleton/pallets/funding/src/functions.rs Outdated Show resolved Hide resolved
polimec-skeleton/pallets/funding/src/tests.rs Show resolved Hide resolved
@lrazovic lrazovic self-requested a review June 26, 2023 15:01
@lrazovic lrazovic merged commit 28c96e9 into main Jun 26, 2023
@lrazovic lrazovic deleted the feature/plmc-209-bondtype-changes branch July 13, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants