Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new
ReleaseSchedule
trait #49Add a new
ReleaseSchedule
trait #49Changes from 73 commits
f3eabc8
69a52f2
f3fc15e
15d326a
3b10eb1
9f0250e
51e6758
17a8e57
afcd124
2a394d6
a898aba
4f31ef3
280713a
f0f063f
b5830d8
38857e6
8d3f835
065dbe1
926cb93
c513dd6
f3d113b
f3d83aa
90d126c
0f503c6
e726198
2facc32
b32ff48
7ca9262
0bd5d85
927fd91
485cc43
ebc45af
edb84f6
cc1cb23
272b760
4489e8c
79a616c
5cd3a9f
dee16ba
6affad0
cca032c
0b3beb8
69ff08e
d5b4430
1020a30
640ce58
749be27
ef0f2e9
daac339
2b0a9ac
fc4c5b9
528e6f0
a8baa84
f57bd6a
fb2fb80
4617300
384b203
15371ac
b6ee734
295c3da
0f1d2e6
3d4b136
499e2b3
326977a
78506e6
0706439
e8916c9
61663e3
9274cbd
434e29e
e7f9b1f
87b89b8
5db9099
c68e994
0817995
3d14489
c9f89c9
ff1432f
a53332a
729f6e2
435210a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood correctly, this means that funds that are locked (or "held") can still be used for paying fees, transaction costs, and tipping. Is this the behavior we want?
I can imagine someone with locked PLMC that wants it out could just tip the whole locked amount to another account of his to take the money out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need much documentation right now for this pallet, but let's remove the deprecated info from the template at least
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 729f6e2.