Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tightly couple the evaluation success threshold to the early reward threshold #50

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 21, 2023

The early reward threshold is chosen always as the threshold for a successful evaluation. We should use a single config type when referring to both concepts in the code

@linear
Copy link

linear bot commented Jul 21, 2023

@JuaniRios JuaniRios requested a review from lrazovic July 21, 2023 10:04
@JuaniRios JuaniRios self-assigned this Jul 21, 2023
@JuaniRios JuaniRios marked this pull request as ready for review July 21, 2023 10:05
@lrazovic lrazovic merged commit 4cadd26 into main Jul 21, 2023
@lrazovic lrazovic deleted the feature/plmc-220-tightly-couple-the-evaluation-success-threshold-to-the-early branch July 21, 2023 11:33
@lrazovic lrazovic restored the feature/plmc-220-tightly-couple-the-evaluation-success-threshold-to-the-early branch July 21, 2023 11:52
@lrazovic lrazovic deleted the feature/plmc-220-tightly-couple-the-evaluation-success-threshold-to-the-early branch October 11, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants