Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plmc 229 implement new vesting pallet on plmc bond #64

Merged

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Aug 8, 2023

  • Fixed bugs in vesting pallet
  • Implemented automatic vest scheduling start on state machine
  • implemented manual vesting as extrinsic
  • full comprehensive tests

@linear
Copy link

linear bot commented Aug 8, 2023

…tions about one function. One new method added for checking total balance locked.

Vest info now calculated when scheduling instead at the time of bidding, since the plmc locked could be reduced if the WAvP is lower than the bid price
…nted and tested.

Automatic vesting scheduling for contributions implemented and tested
@JuaniRios JuaniRios requested a review from lrazovic August 9, 2023 15:29
@JuaniRios JuaniRios self-assigned this Aug 9, 2023
@JuaniRios JuaniRios marked this pull request as ready for review August 9, 2023 15:30
@JuaniRios JuaniRios marked this pull request as draft August 10, 2023 10:47
@JuaniRios
Copy link
Contributor Author

Notes from in-person review:

  • Make sure only successful bids can start the vest schedule
  • Maybe delete StorageItemId since we already constrain it to u32 in the Cleaner + we think 4 billion items is enough for projects/user participations
  • put all imports on the crate level

@JuaniRios JuaniRios marked this pull request as ready for review August 10, 2023 12:12
@JuaniRios JuaniRios added ci-run and removed ci-run labels Aug 10, 2023
@JuaniRios JuaniRios merged commit fbda822 into main Aug 10, 2023
2 checks passed
@lrazovic lrazovic deleted the feature/plmc-229-implement-new-vesting-pallet-on-plmc-bond branch October 11, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant