Feature/plmc 249 remove option from multipliers #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLMC-249 Remove Option from Multipliers
leonardo I think having multiplier as options will only lead to confusion in the best case, and catastrophic failure in the worst case (using default on None). I would say to stop using Option and let the UI decide that the default to give to the chain is 1. |
JuaniRios
force-pushed
the
feature/plmc-249-remove-option-from-multipliers
branch
3 times, most recently
from
2f65bdd
to
fa9ff91
Compare
lrazovic
changed the base branch from
main
to
feature/currency-releases-on-failed-funding
lrazovic
approved these changes
Aug 24, 2023
lrazovic
changed the base branch from
feature/currency-releases-on-failed-funding
to
main
lrazovic
approved these changes
Aug 24, 2023
JuaniRios
force-pushed
the
feature/plmc-249-remove-option-from-multipliers
branch
from
fa9ff91
to
c5d710c
Compare
feat(249): Option no longer required for multipliers fix(243): rebase error chore(243): add import feat(245): manual and automatic release of PLMC and funding assets implemented and tested feat(247): manual and automatic release of PLMC and funding assets implemented and tested feat(247): manual release implemented and tested feat(247): automatic release implemented and tested feat(247): automatic release implemented and tested feat(248): manual release implemented and tested feat(248): automatic release implemented and tested wip feat(242): small optimization chore(242): fmt feat(242): change week to day conversion on config type feat(242): small changes from Leonardo's feedback Update pallets/funding/src/types.rs Co-authored-by: Leonardo Razovic <4128940+lrazovic@users.noreply.github.com> feat(244): linear increase of duration based on vesting wip
JuaniRios
force-pushed
the
feature/plmc-249-remove-option-from-multipliers
branch
from
afe2941
to
1bfadfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.