Feature/plmc 266 add verification code on extrinsic benchmarks #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuaniRios
commented
Oct 17, 2023
| Evaluations::<T>::get((project_id, evaluator.clone(), evaluation_to_unbond.id)).unwrap(); | ||
| assert!(stored_evaluation.rewarded_or_slashed); | ||
| let slashed_amount = T::EvaluatorSlash::get() * evaluation_to_unbond.original_plmc_bond; | ||
| let current_plmc_bond = evaluation_to_unbond.current_plmc_bond.saturating_sub(slashed_amount); |
There was a problem hiding this comment.
In this case the evaluator is not participating in any other round so its fine.
But keep in mind that evaluators can use their plmc bonded in the evaluation phase to participate in bid/contribution rounds.
If this happens then the current_bond is reduced, even though no slash occured.
JuaniRios
commented
Oct 17, 2023
|
|
||
| // validity checks | ||
| assert_eq!(project_status, UpdateType::ProjectDecision(FundingOutcomeDecision::AcceptFunding)); |
There was a problem hiding this comment.
Let's add an event to this
JuaniRios
commented
Oct 17, 2023
|
|
||
| // * validity checks * | ||
| // Storage | ||
| assert!(!Bids::<T>::contains_key((project_id, bidder.clone(), stored_bid.id))); |
There was a problem hiding this comment.
Nice check, will def steal it :D
lrazovic
requested changes
Oct 17, 2023
| current_plmc_bond, | ||
| rewarded_or_slashed, | ||
| .. | ||
| } if project_id == project_id && |
There was a problem hiding this comment.
project_id is always equal to itself, or am I missing something?
pallets/funding/src/benchmarking.rs
Outdated
| evaluator == evaluator.clone() && | ||
| original_plmc_bond == plmc_for_evaluating[0].plmc_amount && | ||
| current_plmc_bond == plmc_for_evaluating[0].plmc_amount && | ||
| rewarded_or_slashed == false => {}, |
There was a problem hiding this comment.
nitpick:
Suggested change
| rewarded_or_slashed == false => {}, | |
| !rewarded_or_slashed => {}, |
lrazovic
approved these changes
Oct 20, 2023
lrazovic
deleted the
feature/plmc-266-add-verification-code-on-extrinsic-benchmarks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.