Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Generate thea auth change message before era ends. #849

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

Gauthamastro
Copy link
Member

@Gauthamastro Gauthamastro commented Jul 26, 2023

Describe your changes

Thea should generate the validator session change message at the beginning of the last epoch of an era and get the changes to effect at the end.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@Gauthamastro Gauthamastro self-assigned this Jul 26, 2023
@Gauthamastro Gauthamastro requested review from serhii-temchenko and zktony and removed request for serhii-temchenko July 26, 2023 07:24
@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Jul 26, 2023
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Jul 26, 2023
@serhii-temchenko
Copy link
Contributor

One test in pallets/thea/src/tests.rs:89:9 with name test_session_change is failing right now with error assertion failed: Thea::outgoing_nonce(1) == 1'

@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19% 🎉

Comparison is base (c6c1572) 38.69% compared to head (448826b) 38.88%.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #849      +/-   ##
===========================================
+ Coverage    38.69%   38.88%   +0.19%     
===========================================
  Files           47       47              
  Lines         2835     2839       +4     
===========================================
+ Hits          1097     1104       +7     
+ Misses        1738     1735       -3     
Files Changed Coverage Δ
runtime/src/lib.rs 0.00% <ø> (ø)
pallets/thea/src/lib.rs 62.83% <100.00%> (+1.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauthamastro Gauthamastro merged commit 5f39dc2 into Develop Jul 27, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the gj/fix-thea-session-change branch July 27, 2023 08:44
Gauthamastro added a commit that referenced this pull request Nov 1, 2023
## Describe your changes
Thea should generate the validator session change message at the
beginning of the last epoch of an era and get the changes to effect at
the end.

## Checklist before requesting a review
- [x] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [x] I removed all Clippy and Formatting Warnings. 
- [ ] I added required Copyrights.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants