Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile build dependencies #853

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Conversation

serhii-temchenko
Copy link
Contributor

Describe your changes

Node build in the docker fails because of not installed required dependencies.

Issue ticket number and link

#833

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@serhii-temchenko serhii-temchenko self-assigned this Jul 28, 2023
@serhii-temchenko serhii-temchenko added the A0-PleaseReview Pull request needs code review. label Jul 28, 2023
@serhii-temchenko serhii-temchenko linked an issue Jul 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.62% 🎉

Comparison is base (f452931) 38.69% compared to head (5c7bf3b) 39.32%.
Report is 32 commits behind head on Develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #853      +/-   ##
===========================================
+ Coverage    38.69%   39.32%   +0.62%     
===========================================
  Files           47       49       +2     
  Lines         2835     3428     +593     
===========================================
+ Hits          1097     1348     +251     
- Misses        1738     2080     +342     

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauthamastro Gauthamastro merged commit 3a7ec8f into Develop Jul 31, 2023
6 checks passed
@Gauthamastro Gauthamastro deleted the hotfix/833/dockerfile branch July 31, 2023 05:03
Gauthamastro added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build docker image erro in v5.2.0
2 participants