Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gj/fix race condition #858

Merged
merged 13 commits into from
Aug 4, 2023
Merged

Gj/fix race condition #858

merged 13 commits into from
Aug 4, 2023

Conversation

Gauthamastro
Copy link
Member

Describe your changes

  1. Offchain state is stored with fullnodes
  2. Bug: state id is now saved with state info ( used in recovery )
  3. Withdrawal race condition is solved for now. There is a TODO for future fix

@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 56.77% and project coverage change: +0.45% 🎉

Comparison is base (3a7ec8f) 39.36% compared to head (bc4b4e3) 39.81%.
Report is 2 commits behind head on Develop.

❗ Current head bc4b4e3 differs from pull request most recent head 2ffee94. Consider uploading reports for the commit 2ffee94 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #858      +/-   ##
===========================================
+ Coverage    39.36%   39.81%   +0.45%     
===========================================
  Files           49       50       +1     
  Lines         2919     2971      +52     
===========================================
+ Hits          1149     1183      +34     
- Misses        1770     1788      +18     
Files Changed Coverage Δ
runtime/src/lib.rs 0.00% <ø> (ø)
pallets/ocex/src/lib.rs 70.27% <14.28%> (-0.47%) ⬇️
pallets/ocex/src/validator.rs 6.07% <15.38%> (-0.08%) ⬇️
pallets/ocex/src/storage.rs 71.31% <79.31%> (+1.69%) ⬆️
pallets/ocex/src/settlement.rs 100.00% <100.00%> (ø)
pallets/ocex/src/snapshot.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Aug 1, 2023
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Aug 2, 2023
@zktony
Copy link
Contributor

zktony commented Aug 2, 2023

LGTM

nuel77
nuel77 previously approved these changes Aug 2, 2023
@zktony zktony self-requested a review August 2, 2023 10:06
@35359595 35359595 added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Aug 2, 2023
runtime/src/lib.rs Outdated Show resolved Hide resolved
pallets/ocex/src/validator.rs Show resolved Hide resolved
pallets/ocex/src/validator.rs Show resolved Hide resolved
@Gauthamastro Gauthamastro merged commit 4a70fe0 into Develop Aug 4, 2023
@Gauthamastro Gauthamastro deleted the gj/fix-race-condition branch August 4, 2023 10:15
Gauthamastro added a commit that referenced this pull request Nov 1, 2023
## Describe your changes

1. Offchain state is stored with fullnodes
2. Bug: state id is now saved with state info ( used in recovery )
3. Withdrawal race condition is solved for now. There is a TODO for
future fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants