Merged Parachain repo #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Describe your changes Upgraded dependencies to 1.1.0.
pavankanteti
requested review from
serhii-temchenko
and removed request for
35359595
serhii-temchenko
requested changes
Sep 21, 2023
4 tasks
# Conflicts: # runtimes/mainnet/Cargo.toml # runtimes/mainnet/src/impls.rs
# Conflicts: # runtimes/parachain/Cargo.toml
## Describe your changes After substrate version update in PR #870 weights of pallets should be updated. In this PR newly generated weights are provided. ## Issue ticket number and link [#241](Polkadex-Substrate/issue-tracker#241) ## Checklist before requesting a review - [X] I have performed a self-review of my code. - [X] If it is a core feature, I have added thorough tests. - [X] I removed all Clippy and Formatting Warnings. - [X] I added required Copyrights. ~~:warning: Note that parachain related pallets weights (e.g. `thea-council` and `xcm-helper`) didn't updated because of error:~~ > ~~Error: Input("Did not find the benchmarking metadata. This could mean that you either did not build the node correctly with the `--features runtime-benchmarks` flag, or the chain spec that you are using was not created by a node that was compiled with the flag: Other: Exported method Benchmark_benchmark_metadata is not found")~~ ~~Even though `--features runtime-benchmarks` flag provided on the build process. @zktony please check this problem.~~ Fixed.
Gauthamastro
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Merged Parachain repo.