Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements after parachain merge #873

Merged
merged 33 commits into from
Nov 1, 2023
Merged

Conversation

serhii-temchenko
Copy link
Contributor

@serhii-temchenko serhii-temchenko commented Sep 25, 2023

Describe your changes

After merge of parachain - CI/CD should be extended with inclusion of parachain.

For the reference - parachain merge implemented in PR #870.

Issue ticket number and link

241

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

⚠️ FIXED (partially in destination PR, partially in this PR) Currently CI is failing since PR #870 is not ready to be merged because of multiple compilation errors which should be fixed before merge of this PR by @zktony. FYI @pavankanteti.

Current issue is described in the comment below. fixed as well.

@serhii-temchenko serhii-temchenko self-assigned this Sep 25, 2023
@serhii-temchenko serhii-temchenko added the A0-PleaseReview Pull request needs code review. label Sep 25, 2023
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 2, 2023
# Conflicts:
#	.github/workflows/ci.yml
#	runtimes/mainnet/Cargo.toml
# Conflicts:
#	runtimes/mainnet/Cargo.toml
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 19, 2023
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 20, 2023
@serhii-temchenko
Copy link
Contributor Author

serhii-temchenko commented Oct 20, 2023

Currently everything ready to be merged. CI is fails because of credentials issue. Reported to devops team.
@pavankanteti FYI.

@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 20, 2023
@serhii-temchenko serhii-temchenko mentioned this pull request Oct 24, 2023
2 tasks
@serhii-temchenko
Copy link
Contributor Author

Currently everything ready to be merged. CI is fails because of credentials issue. Reported to devops team. @pavankanteti FYI.

Now it was fixed. Currently waiting on CI to pass and after that could be merged to the destination branch.

@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 28, 2023
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 30, 2023
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 30, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 31, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 31, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 31, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 304 lines in your changes are missing coverage. Please review.

Comparison is base (bbe2ed9) 36.29% compared to head (df3e210) 36.14%.
Report is 28 commits behind head on zk-reorg.

❗ Current head df3e210 differs from pull request most recent head ace0f65. Consider uploading reports for the commit ace0f65 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           zk-reorg     #873      +/-   ##
============================================
- Coverage     36.29%   36.14%   -0.15%     
============================================
  Files            54       62       +8     
  Lines          3257     3691     +434     
============================================
+ Hits           1182     1334     +152     
- Misses         2075     2357     +282     
Files Coverage Δ
client/src/lib.rs 0.00% <ø> (ø)
nodes/mainnet/src/chain_spec.rs 0.00% <ø> (ø)
pallets/liquidity/src/benchmarking.rs 0.00% <ø> (ø)
pallets/liquidity/src/weights.rs 0.00% <ø> (ø)
pallets/ocex/rpc/src/lib.rs 0.00% <ø> (ø)
pallets/ocex/src/benchmarking.rs 0.00% <ø> (ø)
pallets/ocex/src/storage.rs 75.60% <ø> (ø)
pallets/pdex-migration/src/lib.rs 79.82% <100.00%> (ø)
pallets/rewards/rpc/src/lib.rs 0.00% <ø> (ø)
pallets/rewards/src/benchmarking.rs 0.00% <ø> (ø)
... and 24 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@serhii-temchenko serhii-temchenko requested review from Gauthamastro and zktony and removed request for Gauthamastro and zktony October 31, 2023 09:27
@Gauthamastro Gauthamastro merged commit c5d995b into zk-reorg Nov 1, 2023
@Gauthamastro Gauthamastro deleted the feat/no-ref/ci-fix branch November 1, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants