-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI improvements after parachain merge #873
Conversation
# Conflicts: # dockerfile # runtimes/mainnet/Cargo.toml
# Conflicts: # .github/workflows/ci.yml # runtimes/mainnet/Cargo.toml
# Conflicts: # runtimes/mainnet/Cargo.toml
Currently everything ready to be merged. CI is fails because of credentials issue. Reported to devops team. |
Now it was fixed. Currently waiting on CI to pass and after that could be merged to the destination branch. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## zk-reorg #873 +/- ##
============================================
- Coverage 36.29% 36.14% -0.15%
============================================
Files 54 62 +8
Lines 3257 3691 +434
============================================
+ Hits 1182 1334 +152
- Misses 2075 2357 +282
☔ View full report in Codecov by Sentry. |
Describe your changes
After merge of parachain - CI/CD should be extended with inclusion of parachain.
For the reference - parachain merge implemented in PR #870.
Issue ticket number and link
241
Checklist before requesting a review
Currently CI is failing since PR #870 is not ready to be merged because of multiple compilation errors which should be fixed before merge of this PR by @zktony.FYI @pavankanteti.Current issue is described in the comment below.fixed as well.