Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UX Issues #880

Merged
merged 15 commits into from
Nov 13, 2023
Merged

Fix UX Issues #880

merged 15 commits into from
Nov 13, 2023

Conversation

Gauthamastro
Copy link
Member

@Gauthamastro Gauthamastro commented Nov 3, 2023

Describe your changes

  1. Solves https://github.com/Polkadex-Substrate/orderbook/issues/872
  2. Swap deposit tokens for ED in PDEX automatically
  3. Ability to pay withdrawal fees in tokens
  4. Claim callable by anyone.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@Gauthamastro Gauthamastro self-assigned this Nov 3, 2023
@Gauthamastro Gauthamastro added the A3-InProgress Pull request is in progress. No review needed at this stage. label Nov 3, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A3-InProgress Pull request is in progress. No review needed at this stage. labels Nov 4, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Nov 4, 2023
@Gauthamastro
Copy link
Member Author

@zktony to add test cases for

  • Swap for ED during deposit
  • Swapping for withdrawal fees in Thea
  • Check the situation when swap fails
  • Check the situation when the full deposit/withdrawal amount is used by the swap

@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Nov 7, 2023
@pavankanteti pavankanteti mentioned this pull request Nov 8, 2023
4 tasks
@serhii-temchenko
Copy link
Contributor

CI is still failing, please take a look.

@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Nov 10, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (5f0a92f) 36.12% compared to head (3d790b1) 36.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #880      +/-   ##
===========================================
- Coverage    36.12%   36.11%   -0.01%     
===========================================
  Files           62       62              
  Lines         3693     3741      +48     
===========================================
+ Hits          1334     1351      +17     
- Misses        2359     2390      +31     
Files Coverage Δ
pallets/ocex/src/benchmarking.rs 0.00% <ø> (ø)
pallets/ocex/src/lib.rs 69.32% <100.00%> (+0.29%) ⬆️
pallets/thea-executor/src/benchmarking.rs 0.00% <ø> (ø)
runtimes/mainnet/src/lib.rs 0.00% <0.00%> (ø)
primitives/polkadex/src/assets.rs 46.91% <0.00%> (-7.38%) ⬇️
pallets/thea-executor/src/lib.rs 63.31% <47.91%> (-6.26%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@serhii-temchenko
Copy link
Contributor

@zktony to add test cases for

  • Swap for ED during deposit
  • Swapping for withdrawal fees in Thea
  • Check the situation when swap fails
  • Check the situation when the full deposit/withdrawal amount is used by the swap

I assume this will be resolved in scope of the issue #881 and in different PR.
Approving.

@Gauthamastro Gauthamastro merged commit bfa3582 into Develop Nov 13, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the gj/ux-fixes branch November 13, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants