Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test cases to test swap features #882

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Added test cases to test swap features #882

merged 6 commits into from
Nov 15, 2023

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Nov 13, 2023

Describe your changes

Added test cases to test swap features

Issue ticket number and link

#881

Gauthamastro
Gauthamastro requested changes Nov 14, 2023
View reviewed changes
pallets/thea-executor/src/lib.rs Outdated Show resolved Hide resolved
@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Nov 14, 2023
@Gauthamastro Gauthamastro linked an issue Nov 14, 2023 that may be closed by this pull request
Add test cases #881
Closed
4 tasks
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Nov 14, 2023
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Nov 14, 2023
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Nov 14, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bfa3582) 36.11% compared to head (2bb54e3) 37.52%.

Files Patch % Lines
pallets/thea-executor/src/lib.rs 91.66% 1 Missing ⚠️
primitives/polkadex/src/assets.rs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           Develop     #882      +/-   ##
===========================================
+ Coverage    36.11%   37.52%   +1.40%     
===========================================
  Files           62       62              
  Lines         3741     3750       +9     
===========================================
+ Hits          1351     1407      +56     
+ Misses        2390     2343      -47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gauthamastro
Gauthamastro approved these changes Nov 14, 2023
View reviewed changes
pallets/thea-executor/src/lib.rs Outdated Show resolved Hide resolved
Gauthamastro
Gauthamastro previously approved these changes Nov 14, 2023
View reviewed changes
serhii-temchenko
serhii-temchenko previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@serhii-temchenko serhii-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would be nice to have tested assertions in these functions, but I assume this PR covers only limited scope of functionality. Maybe these assertions could be tested in separate PR?

Approving for now.

pallets/thea-executor/src/lib.rs Outdated Show resolved Hide resolved
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Nov 15, 2023
@Gauthamastro
Copy link
Member

LGTM

@Gauthamastro Gauthamastro merged commit 847f72b into Develop Nov 15, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the zk-added-testcases branch November 15, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhii-temchenko serhii-temchenko serhii-temchenko approved these changes

@Gauthamastro Gauthamastro Gauthamastro approved these changes

Assignees

@zktony zktony

Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test cases
3 participants
@zktony @Gauthamastro @serhii-temchenko