Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdown link checker and CI miss internal <img .../> links being broken #671

Open
nuke-web3 opened this issue Jun 29, 2023 · 3 comments
Open

markdown link checker and CI miss internal <img .../> links being broken #671

nuke-web3 opened this issue Jun 29, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@nuke-web3
Copy link

This may break the build! We need a way to check all links inclusive of non md syntax explicit ones.
@nuke-web3 nuke-web3 added the bug Something isn't working label Jun 29, 2023
@nuke-web3 nuke-web3 changed the title markdown link checker and CI miss internal <img ... links being broken markdown link checker and CI miss internal <img .../> links being broken Jun 29, 2023
@nuke-web3 nuke-web3 mentioned this issue Jul 3, 2023
Closed
@nuke-web3
Copy link
Author

@wirednkod IIRC there was chatter about CI checking - any ideas on this one?

@JoshOrndorff JoshOrndorff mentioned this issue Jul 5, 2023
Closed
@JoshOrndorff
Copy link
Contributor

I cannot reproduce this behavior and I recommend we close this issue. Please see #687 where I introduce a broken link in exactly the kind of tag described here, and the CI properly catches it.

@wirednkod
Copy link
Member

@wirednkod IIRC there was chatter about CI checking - any ideas on this one?

I managed to reproduce (see here but dont merge). This PR (if build is run) has many link issues. I'll try to find the solution on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoshOrndorff @wirednkod @nuke-web3