Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken images #681

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix broken images #681

merged 1 commit into from
Jul 5, 2023

Conversation

wirednkod
Copy link
Member

The issue here is not the "identification" of the inner directories, rather a wrong path given to the source of the image tag.
I have corrected all needed paths and move things around in order to avoid once everything is built, the broken images

Fixes #676

Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thank you @wirednkod

@JoshOrndorff JoshOrndorff merged commit 44833f1 into main Jul 5, 2023
@JoshOrndorff JoshOrndorff deleted the nik-fix-image-paths branch July 5, 2023 10:44
kianenigma pushed a commit that referenced this pull request Jul 19, 2023
move things around and fix all image paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most build images for relative linked assest are broken for yarn build
2 participants