Diagnose link checker #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
reviewed
Jul 5, 2023
| @@ -50,6 +50,9 @@ Crypto not typically used except by military, but upheld guarantees when used. | |||
|
|
|||
| <img src="./img/Web0.png" /> | |||
|
|
|||
| <!-- The following is an intentionally broken link in an img tag. Let's see if the CI catches it. --> | |||
| <img src="https://dujivbiufbdisbvoiwehbivwdfber.com> | |||
There was a problem hiding this comment.
nuke-web3
approved these changes
Jul 5, 2023
The link that is caught is an external link. That is absolutely fine and link checker should get it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is to examine the behavior reported in #671.
When I introduce a broken link in an
<img>tag, the CI catches it.The first few commits from @wirednkod come from #682. We need that for the link checking ci to run in the first place.