Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnose link checker #687

Closed
wants to merge 8 commits into from
Closed

Diagnose link checker #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9eeeac7
Revive link checker
wirednkod Jul 5, 2023
cff20a5
Merge branch 'main' into nik-add-link-check
wirednkod Jul 5, 2023
696a49c
Fix storage link to satisfy link checker
wirednkod Jul 5, 2023
306db8d
Merge branch 'nik-add-link-check' of github.com:Polkadot-Blockchain-A…
wirednkod Jul 5, 2023
64ed953
introduce broken img tag link
JoshOrndorff Jul 5, 2023
87e0b85
fix syntax to make sure CI should fail
JoshOrndorff Jul 7, 2023
f1c50f5
make sure it also fails with trailing slash
JoshOrndorff Jul 7, 2023
70bea43
Should still fail with an INTERNAL link
JoshOrndorff Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/link-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ name: Check Links

on:
push:
branches:
- main
branches: [main]
pull_request:
branches: [main]

jobs:
markdown-link-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3.5.2
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
# links that are okay (http status returns 200) will not be shown
Expand Down
3 changes: 3 additions & 0 deletions syllabus/3-Blockchain/1-Overview_of_Blockchains_slides.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ Crypto not typically used except by military, but upheld guarantees when used.

<img src="./img/Web0.png" />

<!-- The following is an intentionally broken link in an img tag. Let's see if the CI catches it. -->
<img src="./img/Web0_bogus_fdvslhbfvwehgblwhegb.png" />

---

## Web 1
Expand Down
2 changes: 1 addition & 1 deletion syllabus/5-FRAME/2-FRAME_Basics/FRAME_Storage_Slides.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,7 +1325,7 @@ More info in the docs...

### Read the StorageMap Docs for API

https://paritytech.github.io/substrate/master/frame_support/pallet_prelude/struct.StorageMap.html
https://paritytech.github.io/substrate/master/frame_support/storage/types/struct.StorageMap.html

---

Expand Down