Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pba-content public #878

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Make pba-content public #878

merged 4 commits into from
Dec 22, 2023

Conversation

wirednkod
Copy link
Member

@wirednkod wirednkod commented Dec 21, 2023

This PR is adding gh-pages automation to the content. Once the repository becomes public in the settings of the repo (cc @Asamartino ), then we can merge this PR and automate the publication of the content to the pages;

@wirednkod wirednkod changed the title add gh-pages Make pba-content public Dec 21, 2023
@JoshOrndorff
Copy link
Contributor

I certainly support making it public.

I'm curious how this ci job compares to the existing one at https://github.com/Polkadot-Blockchain-Academy/pba-content/blob/main/.github/workflows/ci.yml

It seems Nuke already has the content publishing to ipfs / fleek?

@wirednkod
Copy link
Member Author

I certainly support making it public.

I'm curious how this ci job compares to the existing one at main/.github/workflows/ci.yml

It seems Nuke already has the content publishing to ipfs / fleek?

The difference is simple.
I wrote the gh-publish.yml while I never realised that the ci.yml existed.
Also the script was deploying to IPFS, which I do not find a reason why... (will remove)

Copy link
Collaborator

@Asamartino Asamartino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your help Nikos

@JoshOrndorff
Copy link
Contributor

No strong opinion here, and certainly nothing to block, but I do prefer ipfs to github pages because of the whole centralized-actors-can-censor-stuff problem.

@wirednkod
Copy link
Member Author

No strong opinion here, and certainly nothing to block, but I do prefer ipfs to github pages because of the whole centralized-actors-can-censor-stuff problem.

My intention here is to eventually "place" this in IPFS - BUT under https://polkadot.academy/content link (will mask the IPFS one). I understand the concern of the centralized etc, but for now I'd prefer to place it under github (until I figure out the best decentralized solution)

@wirednkod wirednkod merged commit 3992e80 into main Dec 22, 2023
1 check failed
@wirednkod wirednkod deleted the nik-gh-pages branch December 22, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants