Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit to buff instead of object database (ODB) before signing #35

Open
gchronis opened this issue Mar 23, 2018 · 0 comments
Open

Commit to buff instead of object database (ODB) before signing #35

gchronis opened this issue Mar 23, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@gchronis
Copy link
Contributor

Currently, in order to create signed commit, kevlar-laces creates an unsigned commit and stores it in the ODB, then amends it and adds a signature to the header, returning the second commit. This leaves the repo littered with unused objects. To fix this, we want to use the libgit2 function commit_to_buf, which creates the commit without saving it to the object database first, and then use the commit_signed gitrs method to add the signature and write the commit to the ODB.

The bindings for this particular function have not been added to git2rs.

@clearydude clearydude added the enhancement New feature or request label Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants