Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error if fetching nonexistent reference #56

Open
clearydude opened this issue Jun 14, 2018 · 0 comments
Open

Return error if fetching nonexistent reference #56

clearydude opened this issue Jun 14, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@clearydude
Copy link
Contributor

In the method that validates the correctness of reference locations, all_push_entries_in_fetch_head, it currently fails to return an error if one of the refs we attempted to fetch does not exist.
This should return an error, since git will return a fatal error when attempting to fetch a nonexistent reference. The current non-failure mode may potentially cause the RSL implementation to fail to detect deletion attacks that git DOES detect.

@clearydude clearydude added the bug Something isn't working label Jun 15, 2018
@clearydude clearydude self-assigned this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant