Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Commit

Permalink
remove aria-modal (#96)
Browse files Browse the repository at this point in the history
  • Loading branch information
valdrinkoshi authored Jun 27, 2016
1 parent 49cf1c0 commit a48bbc9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
8 changes: 1 addition & 7 deletions paper-dialog-behavior.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h2>Header</h2>
This element has `role="dialog"` by default. Depending on the context, it may be more appropriate
to override this attribute with `role="alertdialog"`.
If `modal` is set, the element will set `aria-modal` and prevent the focus from exiting the element.
If `modal` is set, the element will prevent the focus from exiting the element.
It will also ensure that focus remains in the dialog.
@hero hero.svg
Expand Down Expand Up @@ -84,12 +84,6 @@ <h2>Header</h2>
},

_modalChanged: function(modal, readied) {
if (modal) {
this.setAttribute('aria-modal', 'true');
} else {
this.setAttribute('aria-modal', 'false');
}

// modal implies noCancelOnOutsideClick, noCancelOnEscKey and withBackdrop.
// We need to wait for the element to be ready before we can read the
// properties values.
Expand Down
10 changes: 0 additions & 10 deletions test/paper-dialog-behavior.html
Original file line number Diff line number Diff line change
Expand Up @@ -400,16 +400,6 @@ <h2 id="header">Dialog</h2>
assert.equal(dialog.getAttribute('role'), 'dialog', 'has role="dialog"');
});

test('dialog has aria-modal=false', function() {
var dialog = fixture('basic');
assert.equal(dialog.getAttribute('aria-modal'), 'false', 'has aria-modal="false"');
});

test('modal dialog has aria-modal=true', function() {
var dialog = fixture('modal');
assert.equal(dialog.getAttribute('aria-modal'), 'true', 'has aria-modal="true"');
});

});
</script>

Expand Down

0 comments on commit a48bbc9

Please sign in to comment.