Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Issue: Cave Story Evo #115

Closed
JeodC opened this issue Feb 21, 2024 · 8 comments · Fixed by #629
Closed

Port Issue: Cave Story Evo #115

JeodC opened this issue Feb 21, 2024 · 8 comments · Fixed by #629

Comments

@JeodC
Copy link
Collaborator

JeodC commented Feb 21, 2024

Cave Story Evo is pretty outdated with the launchscript and oga controls. Spelunky needed a gptokeyb update to accommodate new devices a while ago; this port needs the same treatment. Controls are mapped incorrectly on the Magic XU10.

#68

@JeodC
Copy link
Collaborator Author

JeodC commented Mar 2, 2024

Pull Request #135 recompiled the nxengine-evo binary, which according to some users removed the 720x720 resolution. Need to test the old build against the new build on the RGB30 and verify if the 1:1 aspect ratio was a thing or if the game used a higher resolution that shrunk to fit the screen.

@szelek
Copy link

szelek commented Mar 11, 2024

I don't know if it is the right place to add input about Cave Story controls, but on R36s handheld there are some issues with controls mapping. L2 and R2 are both mapped to C button, Start is recognized as double clicked, D-Pad Left and Right are mapped as direction buttons (which is good) and as prev. and next weapon button (not good).
I am running latest ArkOS from https://github.com/AeolusUX/ArkOS-R3XS
Port Master is updated to the latest version and Cave Story is downloaded directly from Port Master.

@SerpicoSal
Copy link

@JeodC Please let me know if you need additional help testing on a RGB30 and I'll be happy to help.

@JeodC
Copy link
Collaborator Author

JeodC commented Apr 16, 2024

@JeodC Please let me know if you need additional help testing on a RGB30 and I'll be happy to help.

I don't own one so go for it.

@mhoogcarspel
Copy link
Contributor

I don't know how far back we need to go to see this working differently on 720x720 but I tried on latest and commit (3f4a3e86208e742eb2e1cf094ccc56a0a6dd0e19) just before they restructured the renderer in 2.6.5

https://github.com/nxengine/nxengine-evo/releases/tag/v2.6.4

binary from before the last update
https://github.com/PortsMaster/PortMaster-New/blob/884f91a9419705cf29fa15304c063ea33916bfe6/ports/cave.story-evo/nxengine-evo/nxengine-evo

also just has a 640x480 in the top left corner on RGB30
2024-04-18-13-48-16-897156914

The current code doesn't have code for centering or any code to do non-integer scaling as far as I can see

@mhoogcarspel
Copy link
Contributor

Someone actually tried this PR on RGB30 with success
nxengine/nxengine-evo#275

@christianhaitian
Copy link

christianhaitian commented May 31, 2024

If it helps, this was the patch used for adding 720x720 and some other resolutions for this port the last time I built this port. https://github.com/christianhaitian/rk3566_core_builds/blob/master/patches/nxengine-evo-patch-resolution.patch

Also 60fps support: https://github.com/christianhaitian/rk3566_core_builds/blob/master/patches/nxengine-evo-patch-60fps.patch

and rumble support for rk3326 and rk3566 devices that have rumble support that is not native. https://github.com/christianhaitian/rk3566_core_builds/blob/master/patches/nxengine-evo-patch-rumble.patch

For the rg351mp, that should have native rumble support for bsp kernel. maybe mainline as well.

@AchillesPDX
Copy link

I don't know if it is the right place to add input about Cave Story controls, but on R36s handheld there are some issues with controls mapping. L2 and R2 are both mapped to C button, Start is recognized as double clicked, D-Pad Left and Right are mapped as direction buttons (which is good) and as prev. and next weapon button (not good). I am running latest ArkOS from https://github.com/AeolusUX/ArkOS-R3XS Port Master is updated to the latest version and Cave Story is downloaded directly from Port Master.

Very Broken on the RG35XXH running muOS Baked Beans as well. Similar scrambled controls (volume down is even mapped as "yes"). Not sure where to look to fix things properly but I got it in a mostly working state by using the in-game remapping options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants