update decide fixtures

PostHog · Aug 11, 2024 · 6fe151b · 6fe151b
1 parent 245c094
commit 6fe151b
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 53 deletions.
diff --git a/feature_flags_test.go b/feature_flags_test.go
@@ -255,7 +255,7 @@ func TestFlagPersonProperty(t *testing.T) {
 
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-simple-flag-person-prop.json")))
 		}
@@ -329,7 +329,7 @@ func TestFlagGroup(t *testing.T) {
 			if !groupPropertiesEquality {
 				t.Errorf("Expected groupProperties to be map[company:map[name:Project Name 1]], got %s", reqBody.GroupProperties)
 			}
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-flag-group-properties.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/batch/") {
@@ -415,7 +415,7 @@ func TestFlagGroupProperty(t *testing.T) {
 func TestComplexDefinition(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-complex-definition.json"))) // Don't return anything for local eval
 		}
@@ -457,7 +457,7 @@ func TestComplexDefinition(t *testing.T) {
 func TestFallbackToDecide(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte("{}")) // Don't return anything for local eval
 		}
@@ -563,7 +563,7 @@ func TestFeatureFlagsDontFallbackToDecideWhenOnlyLocalEvaluationIsTrue(t *testin
 func TestFeatureFlagDefaultsDontHinderEvaluation(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-false.json")))
 		}
@@ -712,7 +712,7 @@ func TestExperienceContinuityOverride(t *testing.T) {
 func TestGetAllFlags(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-multiple-flags.json")))
 		}
@@ -738,7 +738,7 @@ func TestGetAllFlags(t *testing.T) {
 func TestGetAllFlagsEmptyLocal(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte("{}"))
 		}
@@ -764,7 +764,7 @@ func TestGetAllFlagsEmptyLocal(t *testing.T) {
 func TestGetAllFlagsNoDecide(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-multiple-flags-valid.json")))
 		}
@@ -790,7 +790,7 @@ func TestGetAllFlagsNoDecide(t *testing.T) {
 func TestGetAllFlagsOnlyLocalEvaluationSet(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-get-all-flags-with-fallback-but-only-local-evaluation-set.json")))
 		}
@@ -817,7 +817,7 @@ func TestGetAllFlagsOnlyLocalEvaluationSet(t *testing.T) {
 func TestComputeInactiveFlagsLocally(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-compute-inactive-flags-locally.json")))
 		}
@@ -841,7 +841,7 @@ func TestComputeInactiveFlagsLocally(t *testing.T) {
 
 	server = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-compute-inactive-flags-locally-2.json")))
 		}
@@ -890,7 +890,7 @@ func TestFeatureEnabledSimpleIsTrueWhenRolloutUndefined(t *testing.T) {
 func TestGetFeatureFlag(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-simple-flag-person-prop.json")))
 		}
@@ -949,7 +949,7 @@ func TestFlagWithVariantOverrides(t *testing.T) {
 
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-variant-override.json")))
 		}
@@ -1013,7 +1013,7 @@ func TestFlagWithVariantOverrides(t *testing.T) {
 func TestFlagWithClashingVariantOverrides(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-variant-override-clashing.json")))
 		}
@@ -1079,7 +1079,7 @@ func TestFlagWithClashingVariantOverrides(t *testing.T) {
 func TestFlagWithInvalidVariantOverrides(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-variant-override-invalid.json")))
 		}
@@ -1143,7 +1143,7 @@ func TestFlagWithInvalidVariantOverrides(t *testing.T) {
 func TestFlagWithMultipleVariantOverrides(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-variant-override-multiple.json")))
 		}
@@ -1229,7 +1229,7 @@ func TestFlagWithMultipleVariantOverrides(t *testing.T) {
 func TestCaptureIsCalled(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-simple-flag-person-prop.json")))
 		}
@@ -4434,7 +4434,7 @@ func TestFlagWithTimeoutExceeded(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
 			time.Sleep(1 * time.Second)
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte(fixture("feature_flag/test-flag-group-properties.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/batch/") {
@@ -4535,7 +4535,7 @@ func TestFlagDefinitionsWithTimeoutExceeded(t *testing.T) {
 
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			time.Sleep(11 * time.Second)
 			w.Write([]byte(fixture("feature_flag/test-flag-group-properties.json")))

diff --git a/fixtures/test-decide-v3.json b/fixtures/test-decide-v3.json
@@ -1,33 +1,40 @@
 {
-    "config": {
-        "enable_collect_everything": true
-    },
-    "editorParams": {},
-    "isAuthenticated": true,
-    "supportedCompression": [
-        "gzip",
-        "gzip-js",
-        "lz64"
-    ],
-    "featureFlags": {
-        "enabled-flag": true,
-        "group-flag": true,
-        "disabled-flag": false,
-        "multi-variate-flag": "hello",
-        "simple-flag": true,
-        "beta-feature": "decide-fallback-value",
-        "beta-feature2": "variant-2",
-        "false-flag-2": false,
-        "test-get-feature": "variant-1",
-        "continuation-flag": true
-    },
-    "featureFlagPayloads": {
-        "enabled-flag": "{\"foo\": 1}",
-        "simple-flag": "{\"bar\": 2}",
-        "continuation-flag": "{\"foo\": \"bar\"}",
-        "beta-feature": "{\"foo\": \"bar\"}",
-        "test-get-feature": "this is a string",
-        "multi-variate-flag": "this is the payload"
-    },
-    "sessionRecording": false
-}
+  "config": {
+    "enable_collect_everything": true
+  },
+  "editorParams": {},
+  "isAuthenticated": true,
+  "supportedCompression": ["gzip", "gzip-js", "lz64"],
+  "toolbarParams": {},
+  "featureFlags": {
+    "enabled-flag": true,
+    "group-flag": true,
+    "disabled-flag": false,
+    "multi-variate-flag": "hello",
+    "simple-flag": true,
+    "beta-feature": "decide-fallback-value",
+    "beta-feature2": "variant-2",
+    "false-flag-2": false,
+    "test-get-feature": "variant-1",
+    "continuation-flag": true
+  },
+  "featureFlagPayloads": {
+    "enabled-flag": "{\"foo\": 1}",
+    "simple-flag": "{\"bar\": 2}",
+    "continuation-flag": "{\"foo\": \"bar\"}",
+    "beta-feature": "{\"foo\": \"bar\"}",
+    "test-get-feature": "this is a string",
+    "multi-variate-flag": "this is the payload"
+  },
+  "sessionRecording": false,
+  "errorsWhileComputingFlags": false,
+  "capturePerformance": false,
+  "autocapture_opt_out": true,
+  "autocaptureExceptions": false,
+  "analytics": { "endpoint": "/i/v0/e/" },
+  "__preview_ingestion_endpoints": true,
+  "elementsChainAsString": true,
+  "surveys": false,
+  "heatmaps": false,
+  "siteApps": []
+}
diff --git a/posthog_test.go b/posthog_test.go
@@ -1058,7 +1058,7 @@ func TestGetFeatureFlagPayloadWithNoPersonalApiKey(t *testing.T) {
 func TestGetFeatureFlagWithNoPersonalApiKey(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if !strings.HasPrefix(r.URL.Path, "/batch") {
 			t.Errorf("client called an endpoint it shouldn't have: %s", r.URL.Path)
 		}
@@ -1606,7 +1606,7 @@ func TestMultiVariateFlag(t *testing.T) {
 func TestDisabledFlag(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if strings.HasPrefix(r.URL.Path, "/decide") {
-			w.Write([]byte(fixture("test-decide-v2.json")))
+			w.Write([]byte(fixture("test-decide-v3.json")))
 		} else if strings.HasPrefix(r.URL.Path, "/api/feature_flag/local_evaluation") {
 			w.Write([]byte("{}"))
 		} else if !strings.HasPrefix(r.URL.Path, "/batch") {