Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small error in the config.go documentation #74

Closed
shayn-orca opened this issue Sep 15, 2024 · 2 comments
Closed

Small error in the config.go documentation #74

shayn-orca opened this issue Sep 15, 2024 · 2 comments

Comments

@shayn-orca
Copy link

Hey!

Looks like the config.go docs have a small copy-pasta 🍝:

	// A function called by the client to get the current time, `time.Now` is
	// used by default.
	// This field is not exported and only exposed internally to let unit tests
	// mock the current time.
	now func() time.Time

	// The maximum number of goroutines that will be spawned by a client to send
	// requests to the backend API.
	// This field is not exported and only exposed internally to let unit tests
	// mock the current time.
	maxConcurrentRequests int
}

The documentation above now makes sense, but not above maxConcurrentRequests.

@dmarticus
Copy link
Contributor

You're so right! thanks for noticing, fix is here: #75

@dmarticus
Copy link
Contributor

Should be fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants