Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback capture with empty UUID #71

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Rollback capture with empty UUID #71

merged 10 commits into from
Aug 26, 2024

Conversation

evgeek
Copy link
Contributor

@evgeek evgeek commented Aug 26, 2024

No description provided.

@evgeek evgeek mentioned this pull request Aug 26, 2024
Closed
dmarticus
dmarticus approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@dmarticus dmarticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dmarticus dmarticus merged commit 1409f23 into PostHog:master Aug 26, 2024
1 check passed
@evgeek
Copy link
Contributor Author

evgeek commented Aug 26, 2024 •
edited
Loading

My pleasure :)

@dmarticus, do you think I can expect a fix for /batch behavior with empty uuid in the near future? Or is it not your responsibility and I should propose this fix elsewhere? (where? :))

Or maybe it would be better to just implement this feature at the SDK level in some other way?

@evgeek evgeek deleted the rollback-capture-with-empty-uuid branch August 26, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarticus dmarticus dmarticus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeek @dmarticus