Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid overlap between navbar and directional button #10137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaeelaudibert
Copy link
Member

Changes

On some screen sizes once we have an overflow in the amount of items we display in our navbar, we display a button to allow us to scroll between the items. It just so happens, however, that on some screen sizes there's a terrible overlap between the text and the button. We're now giving much more space to the button and removing that overlap.

Before After
image image

On some screen sizes once we have an overflow in the amount of items we display in our navbar, we display a button to allow us to scroll between the items. It just so happens, however, that on some screen sizes there's a terrible overlap between the text and the button. We're now giving much more space to the button and removing that overlap.
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Dec 13, 2024 6:53pm

@smallbrownbike
Copy link
Collaborator

@rafaeelaudibert I feel like this adds a little too much space on the mobile nav when the arrow button isn't present. And, ideally, that left arrow shouldn't appear when the menu item is fully visible anyway. I'll take a closer look.

Screenshot 2024-12-16 at 10 05 33 AM

@rafaeelaudibert
Copy link
Member Author

rafaeelaudibert commented Dec 16, 2024

@rafaeelaudibert I feel like this adds a little too much space on the mobile nav when the arrow button isn't present.

That makes sense, I can change that to be conditional, but it's fine if you wanna do it as well :)

And, ideally, that left arrow shouldn't appear when the menu item is fully visible anyway. I'll take a closer look.

It isn't fully visible, the AI Engineering bit was offscreen on my desktop :)

@corywatilo
Copy link
Collaborator

corywatilo commented Dec 16, 2024

(We're also going to restructure the subnav a bit which will likely make this all moot anyway) but of course never hurts to handle better

@rafaeelaudibert
Copy link
Member Author

(We're also going to restructure the subnav a bit which will likely make this all moot anyway) but of course never hurts to handle better

Not sure when that's going to happen, but this is so minor that, if that's the case, I'm fine leaving this as is for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants