feat: Programatically add dots to map #10225
Open
+345
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeelaudibert
requested review from
smallbrownbike,
ivanagas and
patricio-posthog
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rafaeelaudibert
commented
Dec 26, 2024
| { | ||
| resolve: `gatsby-mapbox-locations`, | ||
| options: { | ||
| mapboxToken: process.env.MAPBOX_TOKEN, |
There was a problem hiding this comment.
My biggest concern is this.
I set this on Vercel already, I'm using a private token, but I'm happy to create a PostHog one. They have 50,000 requests/month for free, so we shouldn't hit that from production alone, but everytime we run this locally and/or create a preview environment, we'll fetch all of the latitude/longitudes. I'm pretty sure we'll eventually go over 50k/month if we do that. I'm not really sure it's worth it, though.
Other solutions:
- Just add a new latitude/longitude field to our Squeak profile and fetch it from there
- Use their enterprise plan and cache requests, should make it free IIUC?
Instead of having a hardcoded list of dots in our map, we're now collecting the latitude/longitude information from the information we're already collecting from everyone working at PostHog. We're doing some geocoding to transform that information into lat/long pairs. There are some problems with the fact that there isn't much uniformity in the way everyone stores their information, so some dots are extremely innacurate. I've attempted the following pairs and they don't work that well - Location - Location, Country - Location | Country I ultimately settled with the last one because it looks the most accurate - but there are errors still. My suggestion: we should suggest everyone to fill their "Location" field with either a "city, country" tuple or simply the long form of their country name, which **should** make the map more accurate.
rafaeelaudibert
force-pushed
the
programatically-add-dots-to-map
branch
from
a875221 to
ef6f749
Compare
Minor minor minorBTW, there's room to add more people to that map, the code is ready already, we just need a competition to figure out who are the (un)lucky few :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not many people online, and I chose to work on something fun today :)
Instead of having a hardcoded list of dots in our map, we're now collecting the latitude/longitude information from the information we're already collecting from everyone working at PostHog. We're doing some geocoding to transform that information into lat/long pairs.
There are some problems with the fact that there isn't much uniformity in the way everyone stores their information, so some dots are extremely inaccurate.
I've attempted the following pairs and they don't work that well
I ultimately settled with the last one because it looks the most accurate, but there are still errors.
My suggestion: we should suggest everyone to fill their "Location" field with either a "city, country" tuple or simply the long form of their country name, which should make the map more accurate.