Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving the donation modal & projects loading #122

Merged
merged 20 commits into from
May 24, 2024
Merged

Conversation

M-Rb3
Copy link
Member

@M-Rb3 M-Rb3 commented May 22, 2024

  • move the success donation modal for the web wallet to the root.
  • make all the fetching done on the pot page to use bos storage

Copy link
Collaborator

@wpdas wpdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the broken test before merging, please.

Copy link
Collaborator

@wpdas wpdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to work on home page

@M-Rb3 M-Rb3 requested a review from wpdas May 23, 2024 11:56
@wpdas wpdas requested a review from lachlanglen May 23, 2024 15:58
Copy link
Contributor

@lachlanglen lachlanglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially says "0 projects", then says "Loading...", then first load/render of project cards displays essentially blank cards before finally the populated cards are displayed. Would be better to display skeleton cards until the data has loaded, and remove the "Loading..." text.

See video:

Screen.Recording.2024-05-23.at.12.05.40.PM.mov

@wpdas wpdas requested a review from lachlanglen May 23, 2024 22:19
Copy link
Contributor

@lachlanglen lachlanglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still taking a super long time for the projects to load (see screen recording). Is that because we wait to calculate the estimated matched amount for each project card?

Two options:

  1. Refactor so that the estimated matched amounts calculate within the context of the card and not the ListPage component, but this might be tricky / not worth the time

  2. Quick and dirty: remove Estimated Matched Amount from project card, since we have it in "Payouts" now anyway, plus the leaderboard. Just comment out, don't completely delete it, in case we change our minds.

I vote for #2

Screen.Recording.2024-05-23.at.7.36.36.PM.mov

@lachlanglen
Copy link
Contributor

Oh also - please remove the 'Loading...' text in the UI while projects are loading. it should go straight to skeletons.

@M-Rb3
Copy link
Member Author

M-Rb3 commented May 24, 2024

@lachlanglen
the loading is coming from mob. near InfinteScroll component, 😂 I took a look at it, but I have no idea what is going on there, building a new one is easier, I worked with Wenderson on making the card stateless component, which should make it a lot faster now. notify me if you still getting the "loading" text

pot.test.mp4

Copy link
Contributor

@lachlanglen lachlanglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lachlanglen lachlanglen merged commit ac7be60 into staging May 24, 2024
2 checks passed
@lachlanglen lachlanglen deleted the ench/pot-projects branch May 24, 2024 12:51
spandan972 pushed a commit to spandan972/bos-app-alem that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants