Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dgc 2080 pandapower converter datatype different handling #213

Merged

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

Mandatory 'expected_type' field to ensure pandapower input is proper

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@mgovers mgovers merged commit c5f1608 into main Jan 12, 2024
6 of 38 checks passed
@mgovers mgovers deleted the feature/DGC-2080-pandapower-converter-datatype-different-handling branch January 12, 2024 11:06
@mgovers
Copy link
Member

mgovers commented Jan 12, 2024

Whoops apparently i clicked the wrong button here. Also, why was i able to merge this without approval? 🤔 we should fix this. @Jerry-Jinfeng-Guo do you know whether this pr actually broke things? If so, it should be reverted instead of just waiting for a follow-up pr

@mgovers
Copy link
Member

mgovers commented Jan 12, 2024

ohhh nvm i see you based #215 off the wrong branch and then reverted the commits instead of rebasing. that's why these commits are technically part of main and therefore this PR appears as merged. #217 is going to reapply them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants