Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Adding GUID info to the extra_info field #249

Merged
merged 4 commits into from
May 1, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

A test case is included to demonstrate how to add GUID to the extra_info field

…Next to the docs.

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label May 1, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this May 1, 2024
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
mgovers previously approved these changes May 1, 2024
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple nitpicks. very nice example

docs/examples/vision_example.ipynb Outdated Show resolved Hide resolved
docs/examples/vision_example.ipynb Outdated Show resolved Hide resolved
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 3d8eb4c May 1, 2024
31 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/GUID-in-extra-info branch May 1, 2024 12:04
@mgovers
Copy link
Member

mgovers commented May 1, 2024

@Jerry-Jinfeng-Guo
nog een keer

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants