Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filtering option in mapping #256

Merged
merged 15 commits into from
Jun 25, 2024
Merged

filtering option in mapping #256

merged 15 commits into from
Jun 25, 2024

Conversation

nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented Jun 14, 2024 •
edited
Loading

A filtering functionality can now be provided in the mapping. This is to not have an extra component for each row in excel if it doesnt exist.

Changes proposed in this PR include:

  • A filtering functionality in the mapping
  • Note: The validation excel sheets are manually edited as vision 9.4/9.5 was not available to export the test data.

nitbharambe and others added 2 commits June 11, 2024 17:12
@nitbharambe
add table mask
0aa5aca 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@zhen0427
apply test case of version 9_6
580970d 
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
nitbharambe and others added 2 commits June 17, 2024 10:36
@nitbharambe
add the filtering functionality
475e695 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'main' into feature/filtering-option
cc6abe9
@nitbharambe nitbharambe marked this pull request as ready for review June 17, 2024 09:08
@nitbharambe
Copy link
Member Author

Ready for preliminary review about the functionality. The conflicts with tests and different versions shall be resolved in parallel.

@nitbharambe
add sheet name changes to yaml
619894b 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
modify test files
ec912fe 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall question is:

  • Not sure we need to double check if np.sum(table_mask) > 0
    This applies to a couple places

src/power_grid_model_io/converters/tabular_converter.py Show resolved Hide resolved
src/power_grid_model_io/functions/filters.py Outdated Show resolved Hide resolved
@nitbharambe
add unit tests
951ad6d 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
modify 95 tests
51302c2 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
make virtual id work
c6fb24b 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
address quality
2ea2710 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
modify guid tests
3187726 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add constant no filter unit test
77dd9f5 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Copy link
Member Author

Unit test for filter pending. Converting to draft

@nitbharambe nitbharambe marked this pull request as draft June 24, 2024 12:00
@nitbharambe
rename filter add unit test
355edf1 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review June 25, 2024 06:37
@nitbharambe
make table mask default
459ff4a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
rename to filters
18877fe 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit a136e3a Jun 25, 2024
31 checks passed
@mgovers mgovers deleted the feature/filtering-option branch June 25, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left review comments

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitbharambe @Jerry-Jinfeng-Guo @mgovers @zhen0427