Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Ambiguity handling Vision exported Excels #261

Merged
merged 14 commits into from
Jul 5, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo commented Jul 2, 2024

This PR tries to fix the duplicated column issue (#250) from Vision exported Excel files

  • Excel ambiguity checker
  • Introduce new logic to handle ambiguous
  • Unit test

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title Feature/fix duplicated excel column names from Vision Feature / Ambiguity handling Vision exported Excels Jul 2, 2024
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Jul 2, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label Jul 2, 2024
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as ready for review July 3, 2024 15:41
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
nitbharambe
nitbharambe previously approved these changes Jul 5, 2024
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Copy link

sonarqubecloud bot commented Jul 5, 2024

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 15c5574 Jul 5, 2024
31 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/vision-excel-cnvtr-duplicated-column branch July 5, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants